Skip to content
This repository has been archived by the owner on Jan 9, 2023. It is now read-only.

change the .nav-category height to min-height #21

Closed
tangollama opened this issue Sep 22, 2014 · 2 comments
Closed

change the .nav-category height to min-height #21

tangollama opened this issue Sep 22, 2014 · 2 comments
Assignees

Comments

@tangollama
Copy link
Member

It's currently set to 254px on desktop at least. Some of the elements are larger, so I think that needs to be...

.nav-category .category-links {
min-height: 254px;
}

I'd make the change myself, but I don't want to mess with your mojo. If you want me to do it, assign back to me.

cc: @jkleinsc

@jglovier
Copy link
Member

Yeah I struggled a bit with how to work this out when I was mocking it up, because a min-height will break the flow of the cards then, as so:

image

I ended up settling on using overflow: scroll, but the challenge then is that you don't know there are more options unless you actually scroll.

I'm going to try out using overflow: scroll again as a fix, and set the height so that it will at least show some of one of the next buttons. That will provide a visual indicator that there are more options. We can always iterate on the visual indicator later, and if it turns out that hiding some options at all behind a scroll behavior is a bad idea I can rethink this approach later.

So basically FYI I'm punting on the UX of this piece for now by implementing the scroll thing.

@jglovier
Copy link
Member

Cards with additional nav items beyond view look like this for now:

image

matteovivona pushed a commit that referenced this issue Jan 15, 2021
Convert ViewAllergy.test.tsx to RTL
vasanthkumar97 pushed a commit to xcaliber-health/hospitalrun-frontend that referenced this issue Oct 8, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants