Skip to content
This repository has been archived by the owner on Jan 9, 2023. It is now read-only.

Ember Validations deprecations #200

Closed
jkleinsc opened this issue Nov 2, 2015 · 1 comment
Closed

Ember Validations deprecations #200

jkleinsc opened this issue Nov 2, 2015 · 1 comment
Milestone

Comments

@jkleinsc
Copy link
Member

jkleinsc commented Nov 2, 2015

One of the current deprecation errors in our code is caused by deprecated code in Ember Validations:
"Ember.keys is deprecated in favor of Object.keys" - this error message is coming out of the numericality validator in cases where we define a numericality with an operator. For example:

numericality: {
  greaterThan: 0,
}

In addition, given the list of blockers here, we may have some issues using Ember Validations in Ember 2.x: https://github.com/dockyard/ember-validations/labels/2.0-blocker

@jkleinsc jkleinsc added this to the Ember 2.x milestone Nov 2, 2015
@jkleinsc
Copy link
Member Author

jkleinsc commented Dec 7, 2015

Everything seems to be working correctly in Ember 2.2.

@jkleinsc jkleinsc closed this as completed Dec 7, 2015
matteovivona pushed a commit that referenced this issue Jan 15, 2021
ImagingRequestTable.test.tsx - Remove redundant test and clean up
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

1 participant