Skip to content
This repository has been archived by the owner on Jan 9, 2023. It is now read-only.

Reason is incorrectly being marked as required field on edit/new appointment screen #1997

Closed
jackcmeyer opened this issue Apr 20, 2020 · 3 comments · Fixed by #2003
Closed

Reason is incorrectly being marked as required field on edit/new appointment screen #1997

jackcmeyer opened this issue Apr 20, 2020 · 3 comments · Fixed by #2003
Assignees
@JDarke
Labels
🐛bug issue/pull request that documents/fixes a bug good first issue indicates an issue is good for a first time contributor in progress indicates that issue/pull request is currently being worked on scheduling issue/pull request that interacts with scheduling module
Milestone
v2.0

Comments

@jackcmeyer
Copy link
Member

🐛 Bug Report

The reason field is being marked as required when it should not be.

To Reproduce

  1. Navigate to edit or create appointment screen

Expected behavior

The reason should not be marked as required.
@jackcmeyer jackcmeyer added 🐛bug issue/pull request that documents/fixes a bug scheduling issue/pull request that interacts with scheduling module labels Apr 20, 2020
@jackcmeyer jackcmeyer added this to the v2.0 milestone Apr 20, 2020
@jackcmeyer jackcmeyer added help wanted indicates that an issue is open for contributions good first issue indicates an issue is good for a first time contributor labels Apr 20, 2020
@JDarke
Copy link
Contributor

JDarke commented Apr 20, 2020

Hi Jack, I'd like to take a shot at this one for my first actual contribution...

@jackcmeyer
Copy link
Member Author

Sounds great @JDarke. I've assigned this to you

@jackcmeyer jackcmeyer added in progress indicates that issue/pull request is currently being worked on and removed help wanted indicates that an issue is open for contributions labels Apr 21, 2020
JDarke added a commit to JDarke/hospitalrun-frontend that referenced this issue Apr 21, 2020
@JDarke
fix(src/components/input/textfieldwithlabelformgroup.tsx): update Label
1d922c7 
Reason field on new appointment screen no longer a required field.  Line 21, Label element now takes
isRequired attr from interface Props.

fix HospitalRun#1997
@JDarke JDarke mentioned this issue Apr 21, 2020
Merged
@JDarke
Copy link
Contributor

JDarke commented Apr 21, 2020

Hi Jack, I think that fixes it, though I had a bit of a messy time trying to install Yarn, which has modified the package.json. I don't know if you can just accept the commit for the fix and ignore that, or if you need me to submit a new PR?

matteovivona pushed a commit that referenced this issue May 2, 2020
@JDarke
feat(patients): escape string in appointments search (#2031)
254273f 
Fix #1997
Fix #2003
Fix #1999
Fix #2029
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@JDarke JDarke

Labels
🐛bug issue/pull request that documents/fixes a bug good first issue indicates an issue is good for a first time contributor in progress indicates that issue/pull request is currently being worked on scheduling issue/pull request that interacts with scheduling module
Projects
None yet
Milestone
v2.0
2 participants
@jackcmeyer @JDarke