Skip to content
This repository has been archived by the owner on Jan 9, 2023. It is now read-only.

No Related Persons warning not showing actual text #1899

Closed
jackcmeyer opened this issue Mar 13, 2020 · 5 comments · Fixed by #1905
Closed

No Related Persons warning not showing actual text #1899

jackcmeyer opened this issue Mar 13, 2020 · 5 comments · Fixed by #1905
Labels
🐛bug issue/pull request that documents/fixes a bug patients issue/pull request that interacts with patients module
Milestone
v2.0

Comments

@jackcmeyer
Copy link
Member

🐛 Bug Report

The No Related Persons warning text is showing the internationalization keys rather than the actual text.

To Reproduce

  1. Navigate to a patient with no related persons
  2. See that the no related persons warning does not have the proper text

image

Paste your code here:

Expected behavior

It should have the proper text.
@jackcmeyer jackcmeyer transferred this issue from HospitalRun/hospitalrun Mar 13, 2020
@jackcmeyer jackcmeyer added 🐛bug issue/pull request that documents/fixes a bug patients issue/pull request that interacts with patients module labels Mar 13, 2020
@jackcmeyer jackcmeyer added this to the v2.0 milestone Mar 13, 2020
@Brahyt
Copy link
Contributor

Brahyt commented Mar 13, 2020 •
edited
Loading

@jackcmeyer I would like to take this.

rubencgt added a commit to rubencgt/hospitalrun-frontend that referenced this issue Mar 15, 2020
@rubencgt
fix(HospitalRun#1899): added warning messages
58f9402
@rubencgt
Copy link
Contributor

Hello I created a PR that would fix this.
#1905
please feel free to comment on it.
thanks

@matteovivona
Copy link
Contributor

Hi, @rubencgt thanks for your contribution :) To avoid making other people work for nothing, as written here, we always recommend waiting for the assignment. PR is fine anyway.
@Brahyt thank you for your helpfulness!!

@rubencgt rubencgt mentioned this issue Mar 15, 2020
Merged
@Brahyt
Copy link
Contributor

Brahyt commented Mar 15, 2020

No worries, always excited to help OSS.

@rubencgt
Copy link
Contributor

@tehkapa @Brahyt as this is my PR I didn't know how it works.
next time it wont happen, apologies for the miss-understanding

jackcmeyer added a commit that referenced this issue Mar 15, 2020
@jackcmeyer
Merge pull request #1905 from rubencgt/master
d18431f 
fix(#1899): added warning messages
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
🐛bug issue/pull request that documents/fixes a bug patients issue/pull request that interacts with patients module
Projects
None yet
Milestone
v2.0
Development

Successfully merging a pull request may close this issue.

fix(#1899): added warning messages rubencgt/hospitalrun-frontend
4 participants
@Brahyt @rubencgt @matteovivona @jackcmeyer