-
-
Notifications
You must be signed in to change notification settings - Fork 2.2k
Add internationalization support #141
Comments
Hi, i have been looking for some way to contribute to the project, and i think this is a good issue to work on, since it's a nice way to explore the code base 😄. i notice we are quite far back in terms of ember version, so we would have to use 3.x I18n. would it be a huge task to upgrade the version of ember that we are using ? |
@billybonks One of the things on my todo list is to upgrade to Ember 1.13, then fix the deprecation warnings in preparation for Ember 2.x Do you know how much of a difference there is between 3.x i18n and 4.x? If they are significantly different, I would prefer to wait until we can pull in 4.x. |
@billybonks, given that this conversation went cold back in July b/c of the upgrade work, I'm guessing you didn't start anything with this; but I wanted to ask if this was on your radar or if I should be looking for someone else to look into it? No worries either way. Just asking. |
@tangollama, let me try set this up this weekend otherwise, ill drop it 👍 my time has been limited lately |
Word. |
@billybonks Any update on this?, would love to help out. |
@jonkoops @billybonks had a PR that setup localization and that has been merged and at this point what is needed is to convert all of the templates to use localized text. I was intending on creating issues for each functional area to convert the templates but I haven't done so yet. |
@jkleinsc Alright, let me know when you do then I'll pick some up. |
@mDantas I'll take the Patients module, maybe you can work on the Appointments module at the same time? |
Once all the localization has been completed, we should add [ember-cli-template-lint] https://github.com/rwjblue/ember-cli-template-lint to verify that all of our templates are using translated strings. |
All issues complete. Closing this issue. |
Convert ViewVisit.test.tsx to RTL
In order to support different languages in HospitalRun we need to implement ember-i18n throughout the app
The text was updated successfully, but these errors were encountered: