Layout of navigation needs some fixes

[jkleinsc]

There is an unneeded scrollbar on the navigation pane and the search icon is not in the right place. See attached screenshot:

[jglovier]

What OS/Browser/Ver are you on?

[jglovier]

This is how it looks for me.

[jkleinsc]

OSX Yosemite Chrome 43

[jkleinsc]

I still don't understand why you would use overflow: scroll

[jkleinsc]

FYI... this is using the master branch

[jglovier]

I can't reproduce this. Can we setup a time to screenshare with Screenhero and I can try to diagnose on your machine?

[jglovier]

One thing that's bizarre that stands out to me in your screenshot is the scrollbar styling. Even when scrollbars are present for me in Chrome, they don't affect the layout, and they don't have a white background, they have a transparent background.

It almost seems like you're using a completely different browser than me?

[jglovier]

You're not in a VM or something, right?

[jkleinsc]

@jglovier I just verified this. When I plugin an external monitor, I get the white scrollbars. When I unplug, I get the black scrollbars. Its some weird mac thing. Here is someone else on SO getting the same issue:
http://stackoverflow.com/questions/21157231/mac-os-x-scrollbar-is-sometimes-white-transparent-and-sometimes-black-transpare

[jglovier]

🆒 That's so strange, because I'm on an external monitor and I can't reproduce this. Anyway, glad you found the fix. Thx.

[jglovier]

Also, the SO issue you linked to had to do with the scrollbar color itself, but not the appearance of a scrollbar background that affects the box layout. So that doesn't really explain it.

[jkleinsc]

@jglovier it was my external mouse. When I plugged it in it caused the scrollbars to show. I changed the setting here for Show scroll bars from Automatically based on mouse or trackpad to When scrolling and not it always shows the black bar and only when scrolling:

[jkleinsc]

@jglovier BTW -- I think if we left the overflow: scroll in the issue would reproduce in Windows because windows doesn't automatically hide scrollbars, but this feature in OSX does.

[jglovier]

@jkleinsc whoaaaaa interesting. Good find. 🔍 👀 👍

Reopening because I should address the breakage of the search bar regardless. That's a bit too fragile for my comfort, and who knows what else might trigger those scrollbars (e.g. a scenario where the scrollbar does need to appear for content, and the user has a mouse...like in the Philippines I'm guessing lol).

[jkleinsc]

I think I you factor in for a slightly wider scroll bar it would solve the search icon wrapping to the next line.

Sent from my mobile device

On Jul 9, 2015, at 12:23 PM, Joel Glovier [email protected] wrote:

Whoaaaaa interesting. Good find.

Reopening because I should address the breakage of the search bar regardless. That's a bit too fragile for my comfort, and who knows what else might trigger those scrollbars (e.g. a scenario where the scrollbar does need to appear for content, and the user has a mouse...like in the Philippines I'm guessing lol).

—
Reply to this email directly or view it on GitHub.

[jglovier]

Yup. 👍