Skip to content
This repository has been archived by the owner on Jan 9, 2023. It is now read-only.

Modify navigational paradigm #103

Closed
jglovier opened this issue May 18, 2015 · 16 comments
Closed

Modify navigational paradigm #103

jglovier opened this issue May 18, 2015 · 16 comments
Assignees
Milestone

Comments

@jglovier
Copy link
Member

After a bit of research and studying paradigms of how other similar administrative systems are handling navigation these days, I've come up with a new navagational paradigm that I'd like to implement. The idea would be a persistent sidebar nav (that could be collapsible for maximum screen real estate on desktop or on mobile).

Here's the rough comp of the new system:

img

And collapsed would look like:

img

Some inspiration that I drew from includes:

img

Before I branch and start modifying code (I will open a pull request for this one), any major concerns?

cc @tangollama @jkleinsc

@jkleinsc
Copy link
Member

@jglovier What are you thinking in regards to search?

@jglovier
Copy link
Member Author

@jkleinsc oh - good question. Forgot to add that part in, but there's a couple ways we could handle it. Easiest would be to add an icon below the logo bit and right above the nav items with a spot for search there.

@jglovier
Copy link
Member Author

Here's a mock with the search in place.

img

@jglovier
Copy link
Member Author

So the gear is intended to be a place to put additional options that don't necessarily belong in the primary app navigation, like user settings, admin stuff, logout link, etc.

For example:

image

Right now I'm just putting the Logout link in there, but is it right to assume we will have other items to put in there eventually?


Also, where can I drop basic jQuery to add functionality to this little thing? I remember asking about this before, but it's been so long (a year maybe?) that I can't seem to recall.

@jglovier jglovier mentioned this issue May 28, 2015
7 tasks
@jkleinsc
Copy link
Member

@jglovier the logic for this control belongs in the navigation controller and template and should use Ember to control its operation, not jQuery. For showing/hiding the menu, we simply need to tie an action to the gear (see http://guides.emberjs.com/v1.11.0/templates/actions/)

@jglovier
Copy link
Member Author

For showing/hiding the menu, we simply need to tie an action to the gear (see http://guides.emberjs.com/v1.11.0/templates/actions/)

🤘

@tangollama
Copy link
Member

@jglovier, I feel like we can close this issue. Do you agree?

@tangollama tangollama modified the milestone: HospitalRun 1.0 Oct 14, 2015
@jglovier
Copy link
Member Author

I haven't finished this yet (mobile bit is unresolved still), but if you want to close it out and open a new issue for the mobile styling that's fine with me.

@tangollama
Copy link
Member

@jglovier, should I assign this one to you to finish when you have the time or do you need something from me / JK on this one?

@jglovier
Copy link
Member Author

Yeah, go ahead and assign to me and I'll finish it as soon as I can. 👍 Hoping to find some time before the end of the year to address this.

@jglovier
Copy link
Member Author

For my own reference/reminder, see also #135

@tangollama
Copy link
Member

@jglovier Assigned to you so that you can decide if you need to do it or not.

@tangollama tangollama added the in progress indicates that issue/pull request is currently being worked on label Sep 14, 2016
@jglovier jglovier added the core-team indicates that the issue will be completed by a core team member label Jan 17, 2017
@tangollama tangollama removed the in progress indicates that issue/pull request is currently being worked on label Aug 4, 2017
@tangollama
Copy link
Member

@jglovier bump.

@stale
Copy link

stale bot commented Aug 7, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix indicates an issue/pull request will not be worked on label Aug 7, 2019
@fox1t
Copy link
Member

fox1t commented Aug 7, 2019

@StefanoMiC Take a look on this issue.

@stale stale bot removed the wontfix indicates an issue/pull request will not be worked on label Aug 7, 2019
@fox1t fox1t added v2.x and removed core-team indicates that the issue will be completed by a core team member labels Aug 7, 2019
@fox1t fox1t assigned StefanoMiC and unassigned jglovier Aug 7, 2019
@matteovivona matteovivona removed this from the HospitalRun 1.0 milestone Aug 7, 2019
@stale

This comment has been minimized.

@stale stale bot added the wontfix indicates an issue/pull request will not be worked on label Oct 6, 2019
@matteovivona matteovivona removed the wontfix indicates an issue/pull request will not be worked on label Oct 6, 2019
@matteovivona matteovivona added this to the v2.0.0 milestone Oct 6, 2019
@fox1t fox1t closed this as completed Jan 14, 2020
matteovivona pushed a commit that referenced this issue Jan 15, 2021
…t-issue#85

test(newmedicationrequest.test.tsx): update test file to use RTL
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

6 participants