-
-
Notifications
You must be signed in to change notification settings - Fork 2.2k
Modify navigational paradigm #103
Comments
@jglovier What are you thinking in regards to search? |
@jkleinsc oh - good question. Forgot to add that part in, but there's a couple ways we could handle it. Easiest would be to add an icon below the logo bit and right above the nav items with a spot for search there. |
So the gear is intended to be a place to put additional options that don't necessarily belong in the primary app navigation, like user settings, admin stuff, logout link, etc. For example: Right now I'm just putting the Logout link in there, but is it right to assume we will have other items to put in there eventually? Also, where can I drop basic jQuery to add functionality to this little thing? I remember asking about this before, but it's been so long (a year maybe?) that I can't seem to recall. |
@jglovier the logic for this control belongs in the navigation controller and template and should use Ember to control its operation, not jQuery. For showing/hiding the menu, we simply need to tie an action to the gear (see http://guides.emberjs.com/v1.11.0/templates/actions/) |
🤘 |
@jglovier, I feel like we can close this issue. Do you agree? |
I haven't finished this yet (mobile bit is unresolved still), but if you want to close it out and open a new issue for the mobile styling that's fine with me. |
@jglovier, should I assign this one to you to finish when you have the time or do you need something from me / JK on this one? |
Yeah, go ahead and assign to me and I'll finish it as soon as I can. 👍 Hoping to find some time before the end of the year to address this. |
For my own reference/reminder, see also #135 |
@jglovier Assigned to you so that you can decide if you need to do it or not. |
@jglovier bump. |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
@StefanoMiC Take a look on this issue. |
This comment has been minimized.
This comment has been minimized.
…t-issue#85 test(newmedicationrequest.test.tsx): update test file to use RTL
After a bit of research and studying paradigms of how other similar administrative systems are handling navigation these days, I've come up with a new navagational paradigm that I'd like to implement. The idea would be a persistent sidebar nav (that could be collapsible for maximum screen real estate on desktop or on mobile).
Here's the rough comp of the new system:
And collapsed would look like:
Some inspiration that I drew from includes:
Before I branch and start modifying code (I will open a pull request for this one), any major concerns?
cc @tangollama @jkleinsc
The text was updated successfully, but these errors were encountered: