Skip to content
This repository has been archived by the owner on Jan 9, 2023. It is now read-only.

Commit

Permalink
Switch back to PhantomJS for Travis
Browse files Browse the repository at this point in the history
  • Loading branch information
@jkleinsc
jkleinsc committed Oct 4, 2016
1 parent e17395a commit d71841e
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 15 deletions.
17 changes: 3 additions & 14 deletions .travis.yml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -3,29 +3,18 @@ language: node_js
node_js:
- "4"

dist: trusty
sudo: required

addons:
apt:
sources:
- google-chrome
packages:
- google-chrome-stable
sudo: false

cache:
directories:
- node_modules

matrix:
fast_finish: true

before_install:
- "export DISPLAY=:99.0"
- "sh -e /etc/init.d/xvfb start"
- npm config set spin false
- npm install -g bower
- bower --version
- npm install phantomjs-prebuilt
- node_modules/phantomjs-prebuilt/bin/phantomjs --version

install:
- npm install
Expand Down
2 changes: 1 addition & 1 deletion testem.js
View file
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ module.exports = {
"test_page": "tests/index.html?hidepassed",
"disable_watching": true,
"launch_in_ci": [
"Chrome"
"PhantomJS"
],
"launch_in_dev": [
"Chrome"
Expand Down

1 comment on commit d71841e

@villander
Copy link

@villander villander commented on d71841e Apr 3, 2017 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jkleinsc why you replace chrome for PhantomJS ?

PhantomJS is a fantastic tool. However, as anyone whose deployed projects with a sizable test suite can assert (sorry), its support and stability around the features of modern web applications can be... inconsistent at best -- as with its ability to helpfully debug such issues when they occur.

Fortunately, there's a better solution: headless Chrome.

Please sign in to comment.