Merge pull request #264 from codyarose/codyarose_InputTestIds

feat: add testids to inputs whose labels are not properly connected
HospitalRun · Jan 11, 2021 · c8c61a3 · c8c61a3
2 parents e5e83e3 + e80383e
commit c8c61a3
Show file tree

Hide file tree

Showing 4 changed files with 3 additions and 4 deletions.
diff --git a/src/shared/components/input/DatePickerWithLabelFormGroup.tsx b/src/shared/components/input/DatePickerWithLabelFormGroup.tsx
@@ -27,7 +27,7 @@ const DatePickerWithLabelFormGroup = (props: Props) => {
   } = props
   const id = `${name}DatePicker`
   return (
-    <div className="form-group">
+    <div className="form-group" data-testid={id}>
       <Label text={label} htmlFor={id} isRequired={isRequired} />
       <DateTimePicker
         dateFormat="MM/dd/yyyy"

diff --git a/src/shared/components/input/DateTimePickerWithLabelFormGroup.tsx b/src/shared/components/input/DateTimePickerWithLabelFormGroup.tsx
@@ -16,7 +16,7 @@ const DateTimePickerWithLabelFormGroup = (props: Props) => {
   const { onChange, label, name, isEditable, value, isRequired, feedback, isInvalid } = props
   const id = `${name}DateTimePicker`
   return (
-    <div className="form-group">
+    <div className="form-group" data-testid={id}>
       <Label text={label} isRequired={isRequired} htmlFor={id} />
       <DateTimePicker
         dateFormat="MM/dd/yyyy h:mm aa"

diff --git a/src/shared/components/input/SelectWithLabelFormGroup.tsx b/src/shared/components/input/SelectWithLabelFormGroup.tsx
@@ -35,7 +35,7 @@ const SelectWithLabelFormGroup = (props: Props) => {
   } = props
   const id = `${name}Select`
   return (
-    <div className="form-group">
+    <div className="form-group" data-testid={id}>
       {label && <Label text={label} htmlFor={id} isRequired={isRequired} />}
       <Select
         id={id}

diff --git a/src/shared/components/input/TextFieldWithLabelFormGroup.tsx b/src/shared/components/input/TextFieldWithLabelFormGroup.tsx
@@ -20,7 +20,6 @@ const TextFieldWithLabelFormGroup = (props: Props) => {
       {label && <Label text={label} htmlFor={inputId} isRequired={isRequired} />}
       <TextField
         id={inputId}
-        data-testid={inputId}
         rows={4}
         value={value}
         disabled={!isEditable}