Merge pull request #488 from HospitalRun/stylelint

Stylelint

.stylelintrc

@@ -0,0 +1,60 @@
+{
+  "extends": "stylelint-config-concentric",
+  "plugins": [
+  "stylelint-declaration-use-variable",
+  "stylelint-value-border-zero",
+  "stylelint-scss"
+],
+  "rules":{
+    "declaration-use-variable": "color",
+    "value-border-zero": {
+      "convention": "0"
+    },
+    "scss/at-import-no-partial-extension": true,
+    "scss/at-import-no-partial-leading-underscore": true,
+    "scss/at-extend-no-missing-placeholder": true,
+    "selector-max-compound-selectors": 4,
+    "declaration-bang-space-after": "never",
+    "declaration-bang-space-before": "always",
+    "color-named": "never",
+    "color-no-invalid-hex": true,
+    "color-hex-length": "short",
+    "color-hex-case": "lower",
+    "declaration-block-no-duplicate-properties": true,
+    "declaration-no-important": true,
+    "rule-nested-empty-line-before": ["always-multi-line", {
+      "ignore": ["after-comment"],
+      "except": ["first-nested"]
+      } ],
+    "block-no-empty": true,
+    "no-missing-eof-newline": true,
+    "selector-no-id": true,
+    "number-leading-zero": "never",
+    "indentation": [2, {
+      "ignore": ["value"]
+    } ],
+    "no-duplicate-selectors": true,
+    "max-nesting-depth": 4,
+    "selector-pseudo-element-colon-notation": "double",
+    "selector-no-qualifying-type": [ true, {
+        "ignore": [ "attribute" ]
+      } ],
+    "selector-class-pattern": "[_a-z0-9]+",
+    "shorthand-property-no-redundant-values": true,
+    "declaration-block-semicolon-newline-after": "always-multi-line",
+    "selector-list-comma-newline-after": "always-multi-line",
+    "function-comma-space-after": "never-single-line",
+    "declaration-colon-space-after": "always-single-line",
+    "declaration-colon-space-before": "never",
+    "block-opening-brace-space-before": "always",
+    "function-parentheses-space-inside": "never",
+    "string-quotes": "single",
+    "declaration-block-trailing-semicolon": "always",
+    "no-eol-whitespace": true,
+    "number-no-trailing-zeros": true,
+    "function-url-quotes": "single",
+    "number-zero-length-no-unit": true,
+    "block-opening-brace-newline-after": "always-multi-line",
+    "block-opening-brace-space-after": "always-single-line"
+  }
+}

.travis.yml

@@ -12,7 +12,6 @@ cache:
 before_install:
   - "npm config set spin false"
   - "npm install -g npm@^2"
-  - "gem install scss_lint"
 
 install:
   - npm install -g bower

README.md

@@ -16,14 +16,13 @@ To install the frontend please do the following:
 3. Install [ember-cli latest](https://www.npmjs.org/package/ember-cli): `npm install -g ember-cli@latest`.
    Depending on your [npm permissions](https://docs.npmjs.com/getting-started/fixing-npm-permissions) you might need root access to install ember-cli.
 4. Install [bower](https://www.npmjs.org/package/bower): `npm install -g bower`
-5. Make sure you have Ruby installed (for the scss linter).
-6. Clone this repo with `git clone https://github.com/HospitalRun/hospitalrun-frontend`, go to the cloned folder and run `script/bootstrap`. (*Note: Depending on your [npm permissions](https://docs.npmjs.com/getting-started/fixing-npm-permissions) you might need root access to install PhantomJS2; also, Windows users must run with [Cygwin](http://cygwin.org/)*, and will need to install Ruby)
-7. Install and configure [CouchDB](http://couchdb.apache.org/)
+5. Clone this repo with `git clone https://github.com/HospitalRun/hospitalrun-frontend`, go to the cloned folder and run `script/bootstrap`. (*Note: Depending on your [npm permissions](https://docs.npmjs.com/getting-started/fixing-npm-permissions) you might need root access to install PhantomJS2; also, Windows users must run with [Cygwin](http://cygwin.org/)*.
+6. Install and configure [CouchDB](http://couchdb.apache.org/)
     1. Download and install CouchDB from http://couchdb.apache.org/#download
     2. Create admin user:
         1. If you have just installed CouchDB and have no admin user, please run `./script/initcouch.sh` in the folder you cloned the HospitalRun repo.  A user `hradmin` will be created with password: `test`.
         2. If you already have a CouchDB admin user, please run `./script/initcouch.sh USER PASS` in the folder you cloned the HospitalRun repo.  `USER` and `PASS` are the CouchDB admin user credentials.
-8. Copy the `server/config-example.js` to `server/config.js` in the folder you cloned the HospitalRun repo.  If you already had a CouchDB admin user that you passed into the couch script (`./script/initcouch.sh USER PASS`), then you will need to modify the `couchAdminUser` and `couchAdminPassword` values in `server/config.js` to reflect those credentials.
+7. Copy the `server/config-example.js` to `server/config.js` in the folder you cloned the HospitalRun repo.  If you already had a CouchDB admin user that you passed into the couch script (`./script/initcouch.sh USER PASS`), then you will need to modify the `couchAdminUser` and `couchAdminPassword` values in `server/config.js` to reflect those credentials.
 
 ### Experimental
 

app/styles/_base.scss

@@ -1,7 +1,7 @@
 body {
   background: $blue_lightest;
 
-  &.ember-application {
+  &.ember-application {/* stylelint-disable-line selector-no-qualifying-type */
     padding-left: 275px; // to accomodate for .sidebar-nav
   }
 }