Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RFC] Remove some unnessecary configs #35

Closed
3 tasks done
boredsquirrel opened this issue May 30, 2023 · 3 comments
Closed
3 tasks done

[RFC] Remove some unnessecary configs #35

boredsquirrel opened this issue May 30, 2023 · 3 comments
Assignees
Labels
enhancement New feature or request

Comments

@boredsquirrel
Copy link
Contributor

Is your feature request related to a problem? Please describe.
There are some settings that are just plain unnessecary, I havent gone through all, but having them with a user.js means they are forced and cant be changed.

List the concerned preferences

user_pref("mail.SpellCheckBeforeSend", true); //should be optional
user_pref("mail.html_compose", false); //can be changed in GUI, its just a "no HTML killswitch" for paranoid people
user_pref("mail.default_send_format", 0); //defaults to plain text, only changes if you use formatting, best experience
user_pref("mail.inline_attachments", true); //where is the problem? In sanitized HTML no images are really shown anyways

Describe alternatives you've considered
changing these settings manually with sed

Checklist

  • I know thunderbird user.js is a template and personal preferences should be stored elsewhere ;
  • The change I want to propose should globally improve the usability / ( privacy + security + anti-fingerprinting ) ratio ;
  • I agree that subsequent modifications to my change scope may occur in the future.
@boredsquirrel boredsquirrel added the enhancement New feature or request label May 30, 2023
@boredsquirrel
Copy link
Contributor Author

great work by the way! I will use it and automate my modifications

@HorlogeSkynet
Copy link
Owner

Hello @trytomakeyouprivate,

but having them with a user.js means they are forced and cant be changed.

This project uses user_pref directives (not locked), this means that they can be changed (either manually from about:config at runtime, automatically using a TB add-on, and mainly from another user_pref at the end of your user.js.

My two cents below about your removals proposal :

  • mail.SpellCheckBeforeSend has not been touched since initial release : I'm okay for a "reset" ;
  • about mail.html_compose & mail.default_send_format, we already discussed this in enabled HTML and Text sending #34 ;
  • mail.inline_attachments is disabled to force TB to show "inline" attachments as simple (external) ones, including the ones that can be "rendered" (based on MIME Content-Disposition).
    Even if, as you pointed out, images are out of the equation here as we sanitize HTML with mailnews.display.html_as, I'd rather let "inlining" globally disabled.
    However, during my source code wanderings, I also encountered mail.inline_attachments.text that we may add to the template (left to default though).

I would like to remind you that this project is a template that you should adapt according to your needs. From a "code" point of view, it can be forked and maintained as a personal GitHub project (where you would "merge" new upstream changes), or simply locally cloned with manual overrides.

great work by the way! I will use it and automate my modifications

Thanks 🙇
If you happen to tweak Arkenfox upstream scripts (as partially proposed in arkenfox/user.js#910), please open a PR here (also see related #1 and #10) !


A dead-simple "script" (which does not handle preferences "reset" in prefs.js) could be :

cat template-user.js user-override.js > user.js

HorlogeSkynet pushed a commit that referenced this issue Jul 15, 2023
HorlogeSkynet pushed a commit that referenced this issue Jul 15, 2023
This preference controls whether "text attachments" (e.g. CSV, HTML or even plain text) should **also** be directly rendered in message body.

> see #35
@HorlogeSkynet
Copy link
Owner

Closing here as above proposals have been added, bye 👋

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Development

No branches or pull requests

2 participants