Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update circuit setup interfaces to new PROOF_PLUS_VK_SIZE threshold #72

Closed
DanieleDiBenedetto opened this issue Nov 24, 2021 · 1 comment · Fixed by #73
Closed

Update circuit setup interfaces to new PROOF_PLUS_VK_SIZE threshold #72

DanieleDiBenedetto opened this issue Nov 24, 2021 · 1 comment · Fixed by #73
Labels
bug Something isn't working

Comments

@DanieleDiBenedetto
Copy link
Collaborator

Currently, the setup() function in NaiveThresholdSigProof class accepts maxProofSize and maxVkSize; In reality those don't really matter, what matters is their sum (MC will check proof+vk size being below a certain hardcoded threshold).
Update these functions (also in the SDK) accordingly
@DanieleDiBenedetto DanieleDiBenedetto added the bug Something isn't working label Nov 24, 2021
@DanieleDiBenedetto
Copy link
Collaborator Author

Fixed as part of #73

@DanieleDiBenedetto DanieleDiBenedetto linked a pull request Nov 25, 2021 that will close this issue
CSW #73
Merged
This was referenced Jan 10, 2022
Merged
Merged
@DanieleDiBenedetto DanieleDiBenedetto mentioned this issue Feb 4, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

CSW HorizenOfficial/zendoo-sc-cryptolib
1 participant
@DanieleDiBenedetto