Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update mempool_size_limit.py to fix issue with feerate #601

Merged
merged 1 commit into from
Sep 5, 2023

Conversation

drgora
Copy link
Contributor

@drgora drgora commented Sep 4, 2023

This PR fixes a minor inconsistency in the fee vs. feerate values stored in snapshots created for testing mempool size limitations.
The snapshot is updated accordingly.

Also, few helper functions are moved out of the local class, so that they can be seamlessly used by other tests.

Copy link
Contributor

@a-petrini a-petrini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the update, looks good to me.
I'll use the refactored function for cleaning up the tests on my side.

Copy link
Contributor

@JackPiri JackPiri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR is fine to me (explicitly checked fee rates and everything is ok).
Thanks

@ptagl ptagl merged commit 1ba0c3e into main Sep 5, 2023
@ptagl ptagl deleted the dr/mempool_limit_test_fixup branch September 5, 2023 09:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants