Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove libzendoo hardcoded dependency #565

Merged
merged 2 commits into from
Jun 14, 2023

Conversation

la10736
Copy link
Collaborator

@la10736 la10736 commented Jun 9, 2023

The legacy implementation inherit from the librustzcash needs to define a dependency for each crate used from libzendoo. This implementation create a local cargo registry and download all crates in this registry : this implementation force to update all these dependency definition every time libzendoo change its dependency... it's just a useless duplication of the Cargo.lock file posted on libzendoo repo.

Later, in another PR, we'll move the Cargo.lock from libzendoo to zen repo in order to create this file just when we freeze the branch to prepare the release, provide it to who would rebuild zen from scratch and don't use it at all in developing stage.

@la10736 la10736 requested review from drgora and JackPiri June 9, 2023 15:45
Copy link
Contributor

@JackPiri JackPiri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR is fine to me.
I saw there are some old unused *.mk files (not associated with libzendoo) in the depends/packages directory, we could get rid of them in a later cleaning PR:

  • crate_ff.mk
  • crate_ff_derive.mk
  • crate_fuchsia-cprng.mk
  • crate_group.mk
  • crate_itertools.mk
  • crate_wasi.mk

Thanks,

Copy link
Contributor

@drgora drgora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks very good to me, thanks

Copy link
Contributor

@ptagl ptagl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just to be sure, we performed some synchronization tests with zend on Linux, Windows, and MacOS, and as expected, we didn't find any issues.

Thanks!

@ptagl ptagl merged commit 79dfc49 into main Jun 14, 2023
@ptagl ptagl deleted the md/remove_libzendoo_hardcoded_dependency_zend_560 branch June 14, 2023 10:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants