[ZEND-517] Unnecessary log lines removal

[titusen]

As above

[JackPiri]

Here it is better using already available function FormatVersion, since it makes this in a more concise way and it formats the build number as a suffix.
Please note FormatVersion should be fixed because it doesn't handle CLIENT_VERSION_BUILD=0 case and because it is bugged on beta builds (adding a +1).

[titusen]

Giacomo, I don't think this log line is not needed at all cause the full version with commit is printed here

zen/src/init.cpp

Line 960 in f53067e

LogPrintf("Horizen version %s (%s)\n", FormatFullVersion(), CLIENT_DATE);

[JackPiri]

Left a couple of comments, nothing big but better to address in this PR.

[JackPiri]

Giacomo, I don't think this log line is not needed at all cause the full version with commit is printed here

zen/src/init.cpp

Line 960 in f53067e

LogPrintf("Horizen version %s (%s)\n", FormatFullVersion(), CLIENT_DATE);

Yes, I agree with you. Just remove one among:

• LogPrintf("Horizen version %s (%s)\n", FormatFullVersion(), CLIENT_DATE);
• LogPrintf("Zen version %s (%s)\n", FormatFullVersion(), CLIENT_DATE);

[JackPiri]

The PR is fine to me.
Thanks

[JackPiri]

Sorry I didn't notice the CI failure, BOOST_AUTO_TEST_CASE(test_FormatSubVersion) should be aligned accordingly.

[a-petrini]

PR looks good, thanks!

[drgora]

This is ok for me, thanks