Refactor constraint system #29
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lgiussan
force-pushed
the
refactor_constraint_system
branch
from
1d68af9
to
761b455
Compare
DanieleDiBenedetto
approved these changes
Oct 19, 2021
DanieleDiBenedetto
requested changes
Oct 26, 2021
lgiussan
force-pushed
the
refactor_constraint_system
branch
from
c9063c9
to
78371bf
Compare
DanieleDiBenedetto
requested changes
Oct 26, 2021
src/ahp/constraint_systems.rs
Outdated
| make_matrices_square(cs, num_variables); | ||
| let nnz = num_non_zero(cs); | ||
| let matrix_dim = padded_matrix_dim(num_variables, cs.num_constraints); | ||
| make_matrices_square_helper(cs, num_variables); |
There was a problem hiding this comment.
Why another function ?
There was a problem hiding this comment.
It's not really a new function. I did the following renaming:
make_matrices_square_for_indexer_and_prover--->make_matrices_squaremake_matrices_square--->make_matrices_square_helper
Function 1. is just a wrapper around function 2. which computes the right number of variables and performs some checks on the matrix dimensions.
Do you think that make_matrices_square_helper should be eliminated and its code copy-pasted inside make_matrices_square?
DanieleDiBenedetto
approved these changes
Oct 26, 2021
lgiussan
force-pushed
the
refactor_constraint_system
branch
from
54a5ff6
to
b792d5b
Compare
albertog78
approved these changes
Feb 4, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Alignment with ConstraintSystem refactoring on GingerLib: