Default value parameters and variadic detection #69
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chore: prepare support of new class as default value
leohubert
commented
Sep 1, 2022
| o: declaration.questionToken !== undefined || declaration.initializer !== undefined, | ||
| o: declaration.questionToken !== undefined || declaration.initializer !== undefined || declaration.dotDotDotToken !== undefined, | ||
| var: !!declaration?.dotDotDotToken, | ||
| dv: type?.isClass() ? null /*TODO: handle class, but how ? */ : declaration.initializer, |
There was a problem hiding this comment.
@Hookyns, do you know how to handle private foo: Foo = new Foo() here?
I can't find a documentation link for this part of typescript...
There was a problem hiding this comment.
What do you mean "handle it"? detecting runtime values of parameters is out of scope I think.
|
@leohubert is there any progress? |
It's working fine, except for this use case. class Test {
constructor(foo: Foo = new Foo()) { }
}I don't have time to work on it right now but when I find some, I will continue the investigation :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #66