This repository has been archived by the owner on Jan 16, 2025. It is now read-only.
haskell: fix empty flags build failures #49425
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes a regression introduced by Homebrew#47950 in 9e3ee3e causing build failures with the error cabal: The file does not exist ''. This will occur whenever the optional :flags key isn't in the options hash passed to install_cabal_package.
|
@MikeMcQuaid @DomT4 This regression causes nearly every Haskell build to fail :) |
| @@ -81,7 +81,7 @@ def install_cabal_package(*args) | |||
| end | |||
|
|
|||
| args_and_flags = args | |||
| args_and_flags << flags | |||
| args_and_flags << flags unless flags.empty? | |||
There was a problem hiding this comment.
Do we prefer this, or flags.strip.empty?, or something else?
There was a problem hiding this comment.
unless flags.empty? seems fine to me, personally.
|
Thanks again @ilovezfs! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a regression introduced by #47950 in 9e3ee3e causing build
failures with the error
cabal: The file does not exist ''.
This will occur whenever the optional :flags key isn't in the options
hash passed to install_cabal_package.