This repository has been archived by the owner on Jul 4, 2023. It is now read-only.
iojs 1.1.0 #36518
Closed
iojs 1.1.0 #36518
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Version bump, and added the icu4c support already in Node’s devel and head versions, which match to iojs’ current releases.
|
merge this in, please! |
|
@noodlehaus It was only created 9 hours ago, I'm ill and was sleeping. Have some patience and don't post comments like this. |
|
hi @MikeMcQuaid. i'm sorry if my comment came across badly (or if it couldn't come in any other way). i posted it out of excitement and with enthusiasm and was smiling when i found the pull. you and the rest of the maintainers are doing an awesome and thankless job, and i didn't mean any offense with my post. sorry again, and thanks. |
|
@noodlehaus That's OK, I appreciate the apology, thanks! |
|
I think that's the most excited anyone has ever been for one of my PRs 😉 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Version bump, and added the icu4c support already in Node’s devel and head versions, which match to iojs’ current releases.