Skip to content
This repository has been archived by the owner on Jan 16, 2025. It is now read-only.

update libsass to 3.1 release #35558

Closed
wants to merge 1 commit into from
Closed

Conversation

drewwells
Copy link
Contributor

Minor version 3.1.0 of release has landed. This updates the version and sha to the new release "Bulleit Bottle" sass/libsass#697

@DomT4
Copy link
Member

DomT4 commented Jan 5, 2015

The devel do block can be killed, since stable now outdates devel :). Does sassc need a revision to cope with the API changes, or is it good?

@drewwells
Copy link
Contributor Author

I figure we could leave devel around since it will be useful very soon for tracking 3.2. I don't know what the normal practice for homebrew is, but I'd appreciate keeping the code there for easily updating it to 3.2.

I should update sassc, it will be broken.

@DomT4
Copy link
Member

DomT4 commented Jan 5, 2015

It'll need to be chopped, I'm afraid. The bot red-flags a situation where stable outdates devel, because you get the situation where people install devel thinking it's more recent than stable and then the complaints come flooding in 😉. It's a tiny block of code very easily added back in as soon as there's a new devel though :).

The syntax is always

devel do
   url ""
   sha1 ""
end

Cool. Just tack a revision 1 underneath the SHA in the sassc formula and we should be golden.

@drewwells
Copy link
Contributor Author

Ahh okay, I'll remove it. It looks like sassc does not have a 3.1 release. I'll report back what I find about that backwards compat situation.

Well, luckily, SassC is the official binary wrapper for libsass and is always kept in sync.

@DomT4
Copy link
Member

DomT4 commented Jan 5, 2015

It looks like sassc does not have a 3.1 release.

Weird. They're supposed to be released in-sync, as you highlight. Cheers for taking that upstream to ask what the situation is.

I don't know if the arbitrary change will be enough, you may need to make an actual revision to force the bot. Not sure. Guess we'll see 😉.

@drewwells
Copy link
Contributor Author

Fortunately @xzyfer shipped a release of sassc for brew! https://github.com/sass/sassc/releases/tag/3.1.0

@drewwells
Copy link
Contributor Author

I'm getting a lot of strange errors, I'm going to split this commit into two PR

@MikeMcQuaid
Copy link
Member

Thanks for your contribution to Homebrew! For future reference the preferred commit message format for simple version updates is libsass 3.1.0.

@drewwells drewwells deleted the libsass31 branch July 19, 2015 20:34
@Homebrew Homebrew locked and limited conversation to collaborators Feb 17, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants