This repository has been archived by the owner on Jan 16, 2025. It is now read-only.
simh 3.9-0, add fails_with, adjust inreplace #12121
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Upgrade simh to version 3.9-0. Add fails_with :clang. Adjust inreplace because of a modified makefile. Simh will be moving its development to GitHub after 3.9-0. The new webiste is noted in the comments. Over there you can see from the commits that they are supporting Clang. At this time, though, the whole makefile is very closely tied to gcc or llvm-gcc because it queries the `--help` to determine which flags to add to the compile commands. To respect that, and to avoid the dozen warnings from clang at every step, a fails_with :clang is added along with a note to remove it at the next revision. The two `inreplace` commands need to be modified because the makefile changed a lot. This compiles on Lion with XCode-4.3.2.
|
Thanks. |
|
Thanks for your time. I know these changes take extra work. |
Sharpie
pushed a commit
to Sharpie/homebrew
that referenced
this pull request
Sep 12, 2012
Upgrade simh to version 3.9-0. Add fails_with :clang. Adjust inreplace because of a modified makefile. Simh will be moving its development to GitHub after 3.9-0. The new webiste is noted in the comments. Over there you can see from the commits that they are supporting Clang. At this time, though, the whole makefile is very closely tied to gcc or llvm-gcc because it queries the `--help` to determine which flags to add to the compile commands. To respect that, and to avoid the dozen warnings from clang at every step, a fails_with :clang is added along with a note to remove it at the next revision. The two `inreplace` commands need to be modified because the makefile changed a lot. This compiles on Lion with XCode-4.3.2. Closes Homebrew#12121. Signed-off-by: Jack Nagel <[email protected]>
snakeyroc3
pushed a commit
to snakeyroc3/homebrew
that referenced
this pull request
Dec 17, 2012
Upgrade simh to version 3.9-0. Add fails_with :clang. Adjust inreplace because of a modified makefile. Simh will be moving its development to GitHub after 3.9-0. The new webiste is noted in the comments. Over there you can see from the commits that they are supporting Clang. At this time, though, the whole makefile is very closely tied to gcc or llvm-gcc because it queries the `--help` to determine which flags to add to the compile commands. To respect that, and to avoid the dozen warnings from clang at every step, a fails_with :clang is added along with a note to remove it at the next revision. The two `inreplace` commands need to be modified because the makefile changed a lot. This compiles on Lion with XCode-4.3.2. Closes Homebrew#12121. Signed-off-by: Jack Nagel <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgrade simh to version 3.9-0.
Add fails_with :clang.
Adjust inreplace because of a modified makefile.
Simh will be moving its development to GitHub after 3.9-0.
The new webiste is noted in the comments. Over there you can
see from the commits that they are supporting Clang. At
this time, though, the whole makefile is very closely tied to
gcc or llvm-gcc because it queries the
--helpto determinewhich flags to add to the compile commands. To respect that,
and to avoid the dozen warnings from clang at every step,
a fails_with :clang is added along with a note to remove it at
the next revision. The two
inreplacecommands need to bemodified because the makefile changed a lot. This compiles on
Lion with XCode-4.3.2.