-
-
Notifications
You must be signed in to change notification settings - Fork 11.3k
htop: re-add of patched version of htop 0.8.2.1 #11727
Conversation
This should probably be named htop-osx as it isn't the same as vanilla htop. Any chance of submitting some your patches upstream? |
This is awesome. Thank you! htop is the tool I miss the most on my Mac OS X. Will this work on Snow Leopard too? |
I am also excited for htop's return to os x! |
+1 |
yay! |
+1, anything stalling this from happening? It feels kinda silly to install this using "git install https://raw.github.com/max-horvath/homebrew/htop/Library/Formula/htop.rb" |
only reason I'm installing macport, would be great to have htop in the repo! |
when I try to run this I get: htop 0.8.2.1 aborted. Please report bug at http://htop.sf.net osx 10.7.3 |
This branch works great for me (and process memory size has finally been fixed). 👍 on the merge from me. |
You know what would be a cool feature is if GitHub allow you to "Tip" a developer. Then instead of thumbs up we could tip like $1.00. To whomever pulled in the feature. I suppose this would put the code at risk.. but man it would be nice. ;) |
kickstarting feature requests? On Wed, May 2, 2012 at 1:25 PM, Mark Evans <
|
Yea! we could do +$$$ and it could say load up 3 dollars in a tip jar, to be cleared only when the feature was merged. ;) |
Shouldn't the money go to the one who writes the patch, instead of to the one who pulls it? |
The puller has got to get paid, son. |
@camillol totally, the person who submitted the pull request should be given the tip $. I like the idea of cash tips, but to start with the money could be a credit towards the person's github subscription.. But this is getting off-topic, the topic is: Who do we need to bribe to get "htop-osx" into homebrew? @MikeMcQuaid this should go in as "htop" because if htop ever merges in support for osx, then it would replace this package. This would making upgrading seamless. |
Hm... Indeed, some pull requests still manage to make it through after only a few weeks. We do need an incentive for admins to keep them hostage for longer! |
Make it htop-osx and add an htop alias. |
@adamv lmao |
I'll merge this when someone PayPals me $10. |
Whats your paypal email? ;) |
GitHub stripped out the |
Ha. I wasn't. I'd send it to you. Doing a brew install htop vs hours of config a debug, $10 dollars is well worth it. |
if you're under the impression I'm above paying bribes for merges, you are On Wed, May 2, 2012 at 7:01 PM, Mike McQuaid <
|
Save up your bribes until you can buy me something awesome like a island made of chocolate. |
I've been running @max-horvath's recipe for a while without any problems. Gets a +1 from me. |
Added in 86cdaf8. Renamed to |
Now everyone please PayPal me all your money so I can buy a boat. @max-horvath If you can try and get this submitted upstream that would be awesome. |
✌️ On Wed, May 2, 2012 at 7:24 PM, Mike McQuaid <
|
Win! Mike You rock! HTOP Installed! Is your paypal email the one you use on GitHub? |
Please don't actually send me any money, seriously. It will change my motivations for working on Homebrew compared to my job. We might one day ask for donations to buy the Homebrew project e.g. some hardware or something. Hold out until then (if we ever do) and donate to the project. Thanks for your kind thoughts though :) |
Put me on the list. You guys save me tons of time. ;) |
Awesome, I'm glad to finally see it in! However, I think the caveat is necessary. I see very different output when running it chmod'ed as root versus my normal account. I can post screenshots if others don't see it as well. |
@apetresc Fair enough, I'll re-add one. |
Caveats added in 72346a6. |
Closes Homebrew#11727. Signed-off-by: Mike McQuaid <[email protected]>
From discussion in Homebrew#11727.
htop installed just fine and runs, however if the terminal window gets beyond 117 in width OR 50 in height it crashes with the following error: htop 0.8.2.1 aborted. Please report bug at http://htop.sf.net HOMEBREW_VERSION: 0.9 |
@max-horvath please update htop-osx with clear instructions to inform you when an abort occurs, thanks. |
Will do. I'm still on holidays.
|
@Thatoneguy12 had this same issue, didn't test anything about the terminal window's size, but building it with anything else than clang (llvm-gcc or gcc) solved for me. Can you try this? |
Please at least open a new issue here, instead of discussing on a closed one. |
Already opened one issue about this: #12081 |
Will fix ASAP ... thanks for the hint.
|
|
Has been fixed with 255acfb ... |
Closes Homebrew#11727. Signed-off-by: Mike McQuaid <[email protected]>
From discussion in Homebrew#11727.
Closes Homebrew#11727. Signed-off-by: Mike McQuaid <[email protected]>
From discussion in Homebrew#11727.
Based on latest patches for version 0.8.2.1 of htop.
Compiles perfectly fine on Lion. Does not crash.