Skip to content
This repository has been archived by the owner on Jul 4, 2023. It is now read-only.

Minor confusion in zsh install warning #24538

Closed
apennebaker opened this issue Nov 20, 2013 · 10 comments
Closed

Minor confusion in zsh install warning #24538

apennebaker opened this issue Nov 20, 2013 · 10 comments

Comments

@apennebaker
Copy link

Is this zsh warning still relevant in Mac OS X 10.9 Mavericks?

$ brew install zsh
...
If you have administrator privileges, you must fix an Apple miss
configuration in Mac OS X 10.7 Lion by renaming /etc/zshenv to
/etc/zprofile, or Zsh will have the wrong PATH when executed
non-interactively by scripts.
...

If so, we should generalize the warning to 10.7 Lion - 10.9 Mavericks. If not, we should say the warning applies to 10.7 Lion - <the last unfixed Mac version>.

@apennebaker
Copy link
Author

Also, people are reporting that in Mavericks, you have to set PATH neither in /etc/zprofile, nor in /etc/zprofile, but in /etc/zshrc.

https://www.google.com/search?hl=en&q=zshenv%20mavericks

@adamv
Copy link
Contributor

adamv commented Nov 23, 2013

I don't use zsh myself, so we would welcome a Pull Request with updated instructions, or one with no instructions and a link to a webpage that included them.

@MikeMcQuaid
Copy link
Member

I do use zsh but not the Homebrew package. I feel a bit uneasy that we're telling people to rename system files.

@adamv
Copy link
Contributor

adamv commented Nov 27, 2013

I'm going to remove the instructions entirely.

@adamv
Copy link
Contributor

adamv commented Nov 27, 2013

Perhaps we should default to not reading /etc.

@MikeMcQuaid
Copy link
Member

@adamv seems sensible for both.

@adamv adamv closed this as completed in 52fe004 Dec 16, 2013
@apennebaker
Copy link
Author

@adamv Thanks!

@cbarrick
Copy link
Contributor

What exactly is the misconfiguration in /etc/zshenv? As far as I can tell, my path is working fine in Mavericks.

/etc/zshenv gets sourced first, always right? And it calls path_helper to set the path, right (or did I add that to my own config)? So what's the problem?

Anyway, currently /etc/zshenv isn't being sourced for me even with --enable-etcdir, but it is with --enable-etcdir=/etc. Working on a pull-request now.

@MikeMcQuaid
Copy link
Member

@FloFra Deleted your comment. Try and be polite next time.

@MikeMcQuaid
Copy link
Member

Note to anyone who complains about this in future: not reading from /etc is what the vast majority of Homebrew formulae do. It's unfortunate that we needed to change the behaviour here but it should have been this way in the first place.

MikeMcQuaid added a commit that referenced this issue Jan 21, 2014
This reverts commit 52fe004.

Conflicts:
	Library/Formula/zsh.rb

References #24538.
References #25719.
ehershey pushed a commit to ehershey/homebrew that referenced this issue Apr 4, 2014
ehershey pushed a commit to ehershey/homebrew that referenced this issue Apr 4, 2014
This reverts commit 52fe004.

Conflicts:
	Library/Formula/zsh.rb

References Homebrew#24538.
References Homebrew#25719.
@Homebrew Homebrew locked and limited conversation to collaborators Feb 17, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants