Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add inline annotations on GitHub Actions #339

Closed
wants to merge 2 commits into from
Closed

Add inline annotations on GitHub Actions #339

wants to merge 2 commits into from

Conversation

jonchang
Copy link
Contributor

This pull request will automatically enable inline annotations on audit issues if GitHub Actions is the detected continuous integration runner.

Example:

@jonchang jonchang self-assigned this Mar 10, 2020
@SMillerDev
Copy link
Member

Can it also do this for brew style?

@jonchang
Copy link
Contributor Author

This is gonna need more time in the oven. actions/toolkit#305 is causing a lot of headaches for what seemed to be a straightforward change.

@jonchang jonchang mentioned this pull request Mar 30, 2020
Merged
4 tasks
jonchang added 2 commits April 14, 2020 19:17
@jonchang
workflows: mount workspace at same path
aee43f6 
This ensures that our Docker-in-Docker setup is the same as the standard
GitHub actions setup.
@jonchang
Add problem matchers for Github Actions
b2660d1
@MikeMcQuaid
Copy link
Member

Resolving the merge conflicts here may be a nightmare. You might want to remake this from scratch.

Another option I was thinking about would be if we just make brew audit output these directly with e.g. https://help.github.com/en/actions/reference/workflow-commands-for-github-actions#setting-an-error-message

@jonchang
Copy link
Contributor Author

I don't have time to work on this right now unfortunately. I'll revisit this (probably in brew audit) when I'm less busy.

@jonchang jonchang closed this May 22, 2020
@jonchang jonchang deleted the gha-matchers branch May 22, 2020 04:06
@lock lock bot added the outdated label Jun 24, 2020
@lock lock bot locked as resolved and limited conversation to collaborators Jun 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@MikeMcQuaid MikeMcQuaid MikeMcQuaid approved these changes

Assignees

@jonchang jonchang

Labels
outdated
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jonchang @SMillerDev @MikeMcQuaid