-
-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
portable-ruby: fix more compiler toolchain references #187
Conversation
We already get rid of the compiler shim references in `rbconfig.rb`, but there are still some more that may not be valid on the target system: $ brew ruby -e 'p RbConfig::CONFIG.select { |k, v| v.match? /gcc-(.*)-\d+/ }' {"RANLIB"=>"gcc-ranlib-11", "NM"=>"gcc-nm-11", "AR"=>"gcc-ar-11"} We can replace them with `ranlib`, `nm`, and `ar`, respectively. This should help to avoid issues like the one spotted in Homebrew/brew#17114.
Maybe the solution for the core problem is to have the Ruby builder use these agnostic names in the first place? Interesting. Portable Ruby. I know RubyInstaller2 for Windows is portable, but never knew that Mac and Linux also have this. |
That's possible too; they can be overridden with
This is for Homebrew's internal use only; we don't advertise it or provide download or support for general usage like RubyInstaller or others do. |
Same has applied to On macOS, this generally isn't a problem since "AR" => "ar",
"CC" => "clang", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, will make a new release soon
Thanks @ZhongRuoyu! |
We already get rid of the compiler shim references in
rbconfig.rb
, but there are still some more that may not be valid on the target system:We can replace them with
ranlib
,nm
, andar
, respectively.This should help to avoid issues like the one spotted in Homebrew/brew#17114.