Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lv2: use brewed python #96190

Closed
wants to merge 1 commit into from
Closed

Conversation

alebcay
Copy link
Member

@alebcay alebcay commented Mar 3, 2022

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

This PR tackles a number of concerns with the lv2 formula.

  • The build system (waf) was using macOS system Python (/usr/bin/env python) to run. Rewrite shebangs (and any included wscripts) to build using [email protected]
  • One of the components that are shipped #{bin}/lv2specgen.py needs Python at runtime. It also needs several Python modules to be present. Create a virtualenv and include the necessary modules; rewrite shebangs to use the virtualenv Python. (AFAICT, this was broken previously, unless you happened to have the necessary dependencies installed where system Python can find them)
  • Add a test block to check that the necessary Python modules are present, and to check the lv2 framework itself by building a small example plugin against it

@BrewTestBot BrewTestBot added the python Python use is a significant feature of the PR or issue label Mar 3, 2022
@alebcay
Copy link
Member Author

alebcay commented Mar 3, 2022

Also - considering that lv2 doesn't really need Python at runtime, but only lv2specgen, I'd be open to making an lv2specgen formula (especially seeing as some other lv2 dependents still seem to have transitive runtime dependency on [email protected]). Another option is to have lv2 use [email protected] for now and then migrate it later, to avoid the audit conflict.

@alebcay alebcay force-pushed the lv2-brewed-python branch 2 times, most recently from 7d0164f to 7f87765 Compare March 4, 2022 14:08
Formula/lv2.rb Outdated Show resolved Hide resolved
@alebcay alebcay force-pushed the lv2-brewed-python branch from 7f87765 to 4d7eeba Compare March 4, 2022 15:02
@BrewTestBot
Copy link
Member

🤖 A scheduled task has triggered a merge.

@github-actions github-actions bot added the outdated PR was locked due to age label Apr 7, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 7, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated PR was locked due to age python Python use is a significant feature of the PR or issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants