Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

blastem: use Python 3 and remove unneeded resources #95337

Closed
wants to merge 1 commit into from

Conversation

danielnachun
Copy link
Member

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

@BrewTestBot BrewTestBot added no ARM bottle Formula has no ARM bottle no Linux bottle Formula has no Linux bottle python Python use is a significant feature of the PR or issue labels Feb 18, 2022
@danielnachun
Copy link
Member Author

@nandahkrishna I think we need to notify the blastem developer that xcf2png from xcftools is unmaintained and broken, and that they can just use imagemagick to convert the XCF files to PNGs, as detailed here: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=982499. I don't know if you want to reach out to them since you were already in contact, or if you want me to do it. Regardless, we'll be able to move this formula off of Python 2 using an existing upstream commit, so it does not need to be deprecated anymore.

Formula/blastem.rb Outdated Show resolved Hide resolved
@BrewTestBot BrewTestBot removed the python Python use is a significant feature of the PR or issue label Feb 18, 2022
@carlocab carlocab added the CI-no-bottles Merge without publishing bottles label Feb 18, 2022
@nandahkrishna
Copy link
Member

I think we need to notify the blastem developer that xcf2png from xcftools is unmaintained and broken, and that they can just use imagemagick to convert the XCF files to PNGs

I've sent them a message.

@danielnachun
Copy link
Member Author

I think we need to notify the blastem developer that xcf2png from xcftools is unmaintained and broken, and that they can just use imagemagick to convert the XCF files to PNGs

I've sent them a message.

Thanks @nandahkrishna!

@danielnachun
Copy link
Member Author

One last question - I think it might make sense for us to add depends_on arch :x86_64 because this is an emulator, and porting emulators to new host architectures is a non-trivial task. So I don't think we can expect this to support ARM64 without a very significant amount of work.

@BrewTestBot
Copy link
Member

🤖 A scheduled task has triggered a merge.

@danielnachun danielnachun deleted the blastem branch March 18, 2022 19:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI-no-bottles Merge without publishing bottles no ARM bottle Formula has no ARM bottle no Linux bottle Formula has no Linux bottle
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants