Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

spades: migrate to [email protected] #87389

Closed
wants to merge 1 commit into from

Conversation

Moisan
Copy link
Member

@Moisan Moisan commented Oct 16, 2021

spades: migrate to [email protected]

@BrewTestBot BrewTestBot added no ARM bottle Formula has no ARM bottle python Python use is a significant feature of the PR or issue labels Oct 16, 2021
@chenrui333
Copy link
Member

test failure on linux

==> /home/linuxbrew/.linuxbrew/Cellar/spades/3.15.3_1/bin/spades.py --test
Traceback (most recent call last):
  File "/home/linuxbrew/.linuxbrew/Cellar/spades/3.15.3_1/bin/spades.py", line 659, in <module>
    main(sys.argv)
  File "/home/linuxbrew/.linuxbrew/Cellar/spades/3.15.3_1/bin/spades.py", line 599, in main
    print_params(log, log_filename, command_line, args, cfg)
  File "/home/linuxbrew/.linuxbrew/Cellar/spades/3.15.3_1/bin/spades.py", line 327, in print_params
    print_used_values(cfg, log)
  File "/home/linuxbrew/.linuxbrew/Cellar/spades/3.15.3_1/bin/spades.py", line 117, in print_used_values
    dataset_data = pyyaml.load(open(cfg["dataset"].yaml_filename))
  File "/home/linuxbrew/.linuxbrew/Cellar/spades/3.15.3_1/share/spades/pyyaml3/__init__.py", line 72, in load
    return loader.get_single_data()
  File "/home/linuxbrew/.linuxbrew/Cellar/spades/3.15.3_1/share/spades/pyyaml3/constructor.py", line 37, in get_single_data
    return self.construct_document(node)
  File "/home/linuxbrew/.linuxbrew/Cellar/spades/3.15.3_1/share/spades/pyyaml3/constructor.py", line 46, in construct_document
    for dummy in generator:
  File "/home/linuxbrew/.linuxbrew/Cellar/spades/3.15.3_1/share/spades/pyyaml3/constructor.py", line 398, in construct_yaml_map
    value = self.construct_mapping(node)
  File "/home/linuxbrew/.linuxbrew/Cellar/spades/3.15.3_1/share/spades/pyyaml3/constructor.py", line 204, in construct_mapping
    return super().construct_mapping(node, deep=deep)
  File "/home/linuxbrew/.linuxbrew/Cellar/spades/3.15.3_1/share/spades/pyyaml3/constructor.py", line 126, in construct_mapping
    if not isinstance(key, collections.Hashable):
AttributeError: module 'collections' has no attribute 'Hashable'

@chenrui333 chenrui333 added CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds. test failure CI fails while running the test-do block labels Oct 17, 2021
@Moisan
Copy link
Member Author

Moisan commented Oct 22, 2021

I opened an issue upstream: ablab/spades#863

@github-actions
Copy link
Contributor

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@github-actions github-actions bot added the stale No recent activity label Nov 12, 2021
@Moisan
Copy link
Member Author

Moisan commented Nov 12, 2021

Closing for now, upstream plans on fixing this within the next release.

@Moisan Moisan closed this Nov 12, 2021
@github-actions github-actions bot added the outdated PR was locked due to age label Dec 13, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 13, 2021
@Moisan Moisan deleted the spades_python310 branch February 9, 2022 13:06
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds. no ARM bottle Formula has no ARM bottle outdated PR was locked due to age python Python use is a significant feature of the PR or issue python-3.10-migration stale No recent activity test failure CI fails while running the test-do block
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants