Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gradle-profiler 0.16.0 #72240

Closed
wants to merge 2 commits into from
Closed

gradle-profiler 0.16.0 #72240

wants to merge 2 commits into from

Conversation

joschi
Copy link
Contributor

@joschi joschi commented Mar 1, 2021

Bump gradle-profiler to version 0.16.0.

Release notes: https://github.com/gradle/gradle-profiler/releases/tag/v0.16.0

  • Have you followed the guidelines for contributing?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing brew install <formula>)?

@BrewTestBot BrewTestBot added bottle unneeded [DEPRECATED] Bottle does not need to be built java Java use is a significant feature of the PR or issue labels Mar 1, 2021
@joschi
Copy link
Contributor Author

joschi commented Mar 1, 2021

The build failure on Apple M1 (11-arm) looks like it's related to the fact that Gradle doesn't support Java 16 (EA) yet.
https://github.com/Homebrew/homebrew-core/pull/72240/checks?check_run_id=2005786736#step:7:243

See also: gradle/gradle#13481

@carlocab
Copy link
Member

carlocab commented Mar 1, 2021

Gradle doesn't support Java 16 (EA) yet

We work around that with gradle by using Java 11 on ARM:

# gradle currently does not support Java 16
if Hardware::CPU.arm?
depends_on "openjdk@11"
else
depends_on "openjdk"
end

env = if Hardware::CPU.arm?
Language::Java.overridable_java_home_env("11")
else
Language::Java.overridable_java_home_env
end
(bin/"gradle").write_env_script libexec/"bin/gradle", env

Can we do something similar here?

@joschi
Copy link
Contributor Author

joschi commented Mar 1, 2021

Can we do something similar here?

@carlocab Sure, I can give it a try.

Should I do it in this PR or in a separate one?

@joschi
Copy link
Contributor Author

joschi commented Mar 3, 2021

@carlocab Seems to have worked. 😄

Copy link
Member

@SMillerDev SMillerDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @joschi ! Without contributions like yours it'd be impossible to keep homebrew going with the high standards that users have come to expect from the project. You can feel good knowing that you've made the world a tiny bit better for homebrew users around the world! 👍 🎉

@BrewTestBot
Copy link
Member

🤖 A scheduled task has triggered a merge.

@joschi joschi deleted the patch-1 branch March 3, 2021 08:41
@github-actions github-actions bot added the outdated PR was locked due to age label Apr 6, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 6, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bottle unneeded [DEPRECATED] Bottle does not need to be built java Java use is a significant feature of the PR or issue outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants