Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cabal-install 3.4.0.0 #71600

Closed

Conversation

chenrui333
Copy link
Member

action-homebrew-bump-formula


Created with brew bump-formula-pr.

@BrewTestBot BrewTestBot added haskell Haskell use is a significant feature of the PR or issue no ARM bottle Formula has no ARM bottle labels Feb 20, 2021
@fishtreesugar
Copy link
Contributor

FYI, cabal-install 3.4 changed its bootstrap script to bootstrap.py, we couldn't use the old way to bootstrap it anymore.

@carlocab
Copy link
Member

carlocab commented Feb 20, 2021

@fishtreesugar would you like to open a new PR with the necessary updates to the formula? It might be a while before @chenrui333 finds the time to fix this.

Also, it would be good if we could build cabal-install with ghc instead of [email protected].

license "BSD-3-Clause"
revision 1
head "https://github.com/haskell/cabal.git", branch: "3.2"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
head "https://github.com/haskell/cabal.git", branch: "3.2"
head "https://github.com/haskell/cabal.git", branch: "3.4"

@carlocab
Copy link
Member

carlocab commented Feb 21, 2021

I don't think removing the patch is going to fix anything... The problem is that the tarball has no bootstrap.sh. We might need a cabal-install 3.2 to bootstrap 3.4?

@chenrui333 chenrui333 added the upstream issue An upstream issue report is needed label Feb 22, 2021
@chenrui333
Copy link
Member Author

relates to haskell/cabal#7289

@chenrui333
Copy link
Member Author

yeah, it is indeed missing the bootstrap files for the artifact. (will revisit the PR later)

@chenrui333 chenrui333 closed this Feb 22, 2021
@chenrui333 chenrui333 added the build failure CI fails while building the software label Feb 22, 2021
@carlocab
Copy link
Member

carlocab commented Feb 23, 2021

Actually, it looks like we can bootstrap 3.4 with the older 3.2.

@fishtreesugar
Copy link
Contributor

Sorry for the late reply.

would you like to open a new PR with the necessary updates to the formula?

It seems a bit complicated to bootstrapping cabal-install without an environment with older cabal-install because the script mention above depending on some fixture generated by tools written by developers.

Actually, it looks like we can bootstrap 3.4 with the older 3.2.

The release.py seems to support it, but the script didn't bundle in the tarball too.

@carlocab
Copy link
Member

I think I can work out how to bootstrap 3.4 with 3.2. However, I'm not sure which ghc to use. Would you know if I can build 3.4 with ghc 9.0.1 or 8.10.4?

@fishtreesugar
Copy link
Contributor

According to the dependencies of cabal-install 3.4 and bunded packages of GHC 9.0, the base package version of GHC 9.0 is 4.15.0.0, but caball-install 3.4 require >=4.8 && <4.15.

I think we should use GHC 8.10.4.

@carlocab carlocab mentioned this pull request Feb 23, 2021
5 tasks
@carlocab
Copy link
Member

Ok. Giving this a try at #71832.

@fishtreesugar
Copy link
Contributor

It looks like openbsd ports figured out how to bootstrapping via bootstrap.py: https://github.com/blackgnezdo/ports/blob/ghc-8.10/devel/cabal/Makefile (haskell/cabal#7289)

@carlocab
Copy link
Member

Won't work for us, because we need a json file that specifies the dependencies for bootstrap.py, like the one here:

https://github.com/blackgnezdo/ports/blob/83db945f59633c848a9ae28627cd8e378e316a09/devel/cabal/Makefile#L83

@BrewTestBot BrewTestBot added the outdated PR was locked due to age label Mar 27, 2021
@Homebrew Homebrew locked as resolved and limited conversation to collaborators Mar 27, 2021
@chenrui333 chenrui333 deleted the bump-cabal-install-3.4.0.0 branch December 18, 2022 05:33
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
build failure CI fails while building the software haskell Haskell use is a significant feature of the PR or issue no ARM bottle Formula has no ARM bottle outdated PR was locked due to age upstream issue An upstream issue report is needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants