-
-
Notifications
You must be signed in to change notification settings - Fork 12.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
buildifier|buildozer: disable because they're not compiling anymore #71330
Conversation
You forgot to split your commits 😅 |
4cbaef1
to
07681ad
Compare
Actually in Go v1.16, we can just use |
@Loyalsoldier this was attempted in #70924 and #70921, but didn't work out. If you know how to fix it, please do open a PR. Thanks! |
@carlocab I have filed an issue to upstream bazelbuild/buildtools#961 Hope they would switch to Go modules instead. And if they don't like the idea, we then can use |
Bazel should be enough to guarantee reproducibility, without the need for Go modules. I don't know why |
Since upstream has enabled go module for buildifier and buildozer in commit bazelbuild/buildtools@f2aed9e . I think it's time to re-enable these two formulas. |
Please make a pull request to fix the builds and re-enable the formula once that commit has actually landed in a release. |
brew install --build-from-source <formula>
, where<formula>
is the name of the formula you're submitting?brew test <formula>
, where<formula>
is the name of the formula you're submitting?brew audit --strict <formula>
(after doingbrew install <formula>
)?