salt: update cffi resource #68490

carlocab · 2021-01-07T17:10:17Z

fxcoudert · 2021-01-07T20:04:35Z

Collecting cffi==1.14.3 😢

carlocab · 2021-01-07T20:07:15Z

Earlier, though: https://github.com/Homebrew/homebrew-core/pull/68490/checks?check_run_id=1663928195#step:7:4758

Collecting cffi>=1.4.0 so 🤷

SMillerDev · 2021-01-08T07:41:45Z

This formula gives issues on every update. Are we sure we still want to ship this?

carlocab · 2021-01-08T11:57:45Z

To be fair at the moment it's giving no greater issues than other formulae that aren't yet ARM-compatible. That said, I don't mind deprecate!/disable! if it starts to do more than that.

carlocab · 2021-01-08T12:00:34Z

@bayandin do we still need to do an inreplace to use a custom cffi as mentioned in this comment? #62864 (comment)

bayandin · 2021-01-08T12:14:30Z

@bayandin do we still need to do an inreplace to use a custom cffi as mentioned in this comment? #62864 (comment)

We do.
Currently all versions are listed in buildpath/"requirements/static/pkg/py#{xy}/darwin.txt". And it has cffi==1.14.3.

carlocab · 2021-01-08T12:16:02Z

Ok, cool, thanks. That's not hard. I'll fix it in a moment. Though, if someone has the time to do it now, please feel free.

bayandin · 2021-01-08T12:25:08Z

Feel involved in the creation of this mess with salt, sorry folks.

I'll have another look at how we can list all dependencies in the formula without pyobjc*

See Homebrew#68463.

carlocab · 2021-01-13T00:36:04Z

The inreplace does get it to build with cffi 1.14.4, but now it won't even pass a salt --version test:

==> brew test --verbose salt
==> FAILED
==> Testing salt
/usr/bin/sandbox-exec -f /private/tmp/homebrew20210112-5661-74v104.sb ruby -W0 -I $LOAD_PATH -- /opt/homebrew/Library/Homebrew/test.rb /opt/homebrew/Library/Taps/homebrew/homebrew-core/Formula/salt.rb --verbose
==> /opt/homebrew/Cellar/salt/3002.2_1/bin/salt --version
WARNING: /opt/homebrew/Cellar/[email protected]/3.9.1_6/Frameworks/Python.framework/Versions/3.9/Resources/Python.app/Contents/MacOS/Python is loading libcrypto in an unsafe way

Error: salt: failed
An exception occurred within a child process:
  Test::Unit::AssertionFailedError: <0> expected but was
<nil>.

It's only happening on ARM, though, so I guess it just really has deeper issues that make it incompatible

bayandin · 2021-01-13T00:59:50Z

@carlocab I've listed all the resources, that we use in salt (generated by slightly modified brew update-python-resources command, and removed all pyobjc*). Hope you don't mind 😄

Will create a PR for update-python-resources to make it easier to support the formula later.

Also, added pkg-config dependency to fix the latest failure:

Installing collected packages: cffi
  Created temporary directory: /private/tmp/pip-record-1y3qeeeh
    Running setup.py install for cffi: started
    Running command /opt/homebrew/Cellar/salt/3002.2_1/libexec/bin/python3.9 -u -c 'import sys, setuptools, tokenize; sys.argv[0] = '"'"'/private/tmp/pip-req-build-zqrfmfe8/setup.py'"'"'; __file__='"'"'/private/tmp/pip-req-build-zqrfmfe8/setup.py'"'"';f=getattr(tokenize, '"'"'open'"'"', open)(__file__);code=f.read().replace('"'"'\r\n'"'"', '"'"'\n'"'"');f.close();exec(compile(code, __file__, '"'"'exec'"'"'))' install --record /private/tmp/pip-record-1y3qeeeh/install-record.txt --single-version-externally-managed --compile --install-headers /opt/homebrew/Cellar/salt/3002.2_1/libexec/include/site/python3.9/cffi
    /opt/homebrew/Library/Homebrew/shims/mac/super/pkg-config: line 9: /opt/homebrew/opt/pkg-config/bin/pkg-config: No such file or directory
    /opt/homebrew/Library/Homebrew/shims/mac/super/pkg-config: line 9: exec: /opt/homebrew/opt/pkg-config/bin/pkg-config: cannot execute: No such file or directory
    /opt/homebrew/Library/Homebrew/shims/mac/super/pkg-config: line 9: /opt/homebrew/opt/pkg-config/bin/pkg-config: No such file or directory
    /opt/homebrew/Library/Homebrew/shims/mac/super/pkg-config: line 9: exec: /opt/homebrew/opt/pkg-config/bin/pkg-config: cannot execute: No such file or directory
    /opt/homebrew/Library/Homebrew/shims/mac/super/pkg-config: line 9: /opt/homebrew/opt/pkg-config/bin/pkg-config: No such file or directory
    /opt/homebrew/Library/Homebrew/shims/mac/super/pkg-config: line 9: exec: /opt/homebrew/opt/pkg-config/bin/pkg-config: cannot execute: No such file or directory
    /opt/homebrew/Library/Homebrew/shims/mac/super/pkg-config: line 9: /opt/homebrew/opt/pkg-config/bin/pkg-config: No such file or directory
    /opt/homebrew/Library/Homebrew/shims/mac/super/pkg-config: line 9: exec: /opt/homebrew/opt/pkg-config/bin/pkg-config: cannot execute: No such file or directory
    /opt/homebrew/Library/Homebrew/shims/mac/super/pkg-config: line 9: /opt/homebrew/opt/pkg-config/bin/pkg-config: No such file or directory
    /opt/homebrew/Library/Homebrew/shims/mac/super/pkg-config: line 9: exec: /opt/homebrew/opt/pkg-config/bin/pkg-config: cannot execute: No such file or directory
...

carlocab · 2021-01-13T01:04:10Z

That's weird; that wasn't there before I added depends_on "libffi"... https://github.com/Homebrew/homebrew-core/runs/1691913764

But, sure, I don't mind the additional changes. Thanks!

carlocab · 2021-01-13T01:05:51Z

Still no luck, sadly

bayandin · 2021-01-13T01:17:00Z

      File "/private/tmp/pip-build-env-mghh8j2q/overlay/lib/python3.9/site-packages/cffi/api.py", line 48, in __init__
        import _cffi_backend as backend
    ImportError: dlopen(/private/tmp/pip-build-env-mghh8j2q/overlay/lib/python3.9/site-packages/_cffi_backend.cpython-39-darwin.so, 2): Symbol not found: _ffi_prep_closure
      Referenced from: /private/tmp/pip-build-env-mghh8j2q/overlay/lib/python3.9/site-packages/_cffi_backend.cpython-39-darwin.so
      Expected in: flat namespace
     in /private/tmp/pip-build-env-mghh8j2q/overlay/lib/python3.9/site-packages/_cffi_backend.cpython-39-darwin.so
    Preparing wheel metadata: finished with status 'error'

That's weird; that wasn't there before I added depends_on "libffi"... https://github.com/Homebrew/homebrew-core/runs/1691913764

Actually, for most of the formulae, we use system libffi, probably we'd like to stick with uses_from_macos "libffi" here as well

carlocab · 2021-01-13T01:18:39Z

Actually, for most of the formulae, we use system libffi, probably we'd like to stick with uses_from_macos "libffi" here as well

Yes, I would also prefer system libffi. I was just trying it to see if it would help...

bayandin · 2021-01-13T01:25:27Z

Formula/salt.rb

@@ -18,61 +19,254 @@ class Salt < Formula
    sha256 "bbc802eb5097a9f2d02b182215ca73eb37bdd841972e321bcaac219c2b530431" => :mojave
  end

+  depends_on "pkg-config" => :build


My bad

Suggested change

depends_on "pkg-config" => :build

bayandin · 2021-01-13T01:37:29Z

I guess that it could be related to the previous huge problem with salt and libcrypto (saltstack/salt#55084) which was fixed by saltstack/salt#56958.

Could anyone check which one libcrypto salt is trying to load on Apple Silicon?

BrewTestBot · 2021-02-03T02:48:43Z

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

carlocab added the CI-force-arm [DEPRECATED] Don't pass --skip-unbottled-arm to brew test-bot. label Jan 7, 2021

BrewTestBot added no ARM bottle Formula has no ARM bottle python Python use is a significant feature of the PR or issue labels Jan 7, 2021

carlocab mentioned this pull request Jan 7, 2021

cffi updates for Apple Silicon #68463

Closed

34 tasks

carlocab force-pushed the salt-cffi branch from 2bb7a0b to c0195cf Compare January 13, 2021 00:19

salt: update cffi resource

601bb58

See Homebrew#68463.

carlocab force-pushed the salt-cffi branch from f6ef77a to 601bb58 Compare January 13, 2021 00:23

carlocab and others added 2 commits January 13, 2021 00:43

depend on brewed libffi

e7658a8

salt: list all required resources

1e16cf1

salt: use system libffi

c0975e5

bayandin reviewed Jan 13, 2021

View reviewed changes

BrewTestBot added the stale No recent activity label Feb 3, 2021

carlocab closed this Feb 5, 2021

carlocab deleted the salt-cffi branch February 5, 2021 14:48

BrewTestBot added the outdated PR was locked due to age label Mar 8, 2021

Homebrew locked as resolved and limited conversation to collaborators Mar 8, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

salt: update cffi resource #68490

salt: update cffi resource #68490

carlocab commented Jan 7, 2021

fxcoudert commented Jan 7, 2021

carlocab commented Jan 7, 2021 •

edited

Loading

SMillerDev commented Jan 8, 2021

carlocab commented Jan 8, 2021

carlocab commented Jan 8, 2021

bayandin commented Jan 8, 2021

carlocab commented Jan 8, 2021

bayandin commented Jan 8, 2021 •

edited

Loading

carlocab commented Jan 13, 2021 •

edited

Loading

bayandin commented Jan 13, 2021 •

edited

Loading

carlocab commented Jan 13, 2021

carlocab commented Jan 13, 2021

bayandin commented Jan 13, 2021

carlocab commented Jan 13, 2021

bayandin Jan 13, 2021 •

edited

Loading

bayandin commented Jan 13, 2021

BrewTestBot commented Feb 3, 2021

salt: update cffi resource #68490

salt: update cffi resource #68490

Conversation

carlocab commented Jan 7, 2021

fxcoudert commented Jan 7, 2021

carlocab commented Jan 7, 2021 • edited Loading

SMillerDev commented Jan 8, 2021

carlocab commented Jan 8, 2021

carlocab commented Jan 8, 2021

bayandin commented Jan 8, 2021

carlocab commented Jan 8, 2021

bayandin commented Jan 8, 2021 • edited Loading

carlocab commented Jan 13, 2021 • edited Loading

bayandin commented Jan 13, 2021 • edited Loading

carlocab commented Jan 13, 2021

carlocab commented Jan 13, 2021

bayandin commented Jan 13, 2021

carlocab commented Jan 13, 2021

bayandin Jan 13, 2021 • edited Loading

Choose a reason for hiding this comment

bayandin commented Jan 13, 2021

BrewTestBot commented Feb 3, 2021

carlocab commented Jan 7, 2021 •

edited

Loading

bayandin commented Jan 8, 2021 •

edited

Loading

carlocab commented Jan 13, 2021 •

edited

Loading

bayandin commented Jan 13, 2021 •

edited

Loading

bayandin Jan 13, 2021 •

edited

Loading