ncview: migrate to brewed X11 #64779
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test not passing. Same issue as with morse: #64333 (comment) It builds fine, but doesn't really work outside of XQuartz. Tracking issue: #64166 - [x] Have you followed the [guidelines for contributing](https://github.com/Homebrew/homebrew-core/blob/HEAD/CONTRIBUTING.md)? - [x] Have you checked that there aren't other open [pull requests](https://github.com/Homebrew/homebrew-core/pulls) for the same formula update/change? - [x] Have you built your formula locally with `brew install --build-from-source <formula>`, where `<formula>` is the name of the formula you're submitting? - [ ] Is your test running fine `brew test <formula>`, where `<formula>` is the name of the formula you're submitting? - [x] Does your build pass `brew audit --strict <formula>` (after doing `brew install <formula>`)? ----- - [x] `brew install FORMULA` on this list (should be poured from a bottle, not built from source) - [x] Run `brew linkage FORMULA` and observe which X11 libraries it links against - [x] Modify the formula to remove `depends_on :x11` and replace it with e.g. `depends_on "libx11"` and any additional X libraries - [x] Update `/opt/X11` or `MacOS::XQuartz` references to instead point them to the brewed formula paths - [x] `revision` bump - [x] `brew install -s FORMULA` and `brew linkage FORMULA` to check that it's now linking against brewed X and not XQuartz ----- Before: ❯ brew linkage ncview System libraries: /opt/X11/lib/libICE.6.dylib /opt/X11/lib/libSM.6.dylib /opt/X11/lib/libX11.6.dylib /opt/X11/lib/libXaw.7.dylib /opt/X11/lib/libXt.6.dylib /usr/lib/libSystem.B.dylib /usr/lib/libexpat.1.dylib Homebrew libraries: /usr/local/opt/libpng/lib/libpng16.16.dylib (libpng) /usr/local/opt/netcdf/lib/libnetcdf.18.dylib (netcdf) /usr/local/opt/udunits/lib/libudunits2.dylib (udunits) After: ❯ brew linkage ncview System libraries: /usr/lib/libSystem.B.dylib /usr/lib/libexpat.1.dylib Homebrew libraries: /usr/local/opt/libice/lib/libICE.6.dylib (libice) /usr/local/opt/libpng/lib/libpng16.16.dylib (libpng) /usr/local/opt/libsm/lib/libSM.6.dylib (libsm) /usr/local/opt/libx11/lib/libX11.6.dylib (libx11) /usr/local/opt/libxaw/lib/libXaw.7.dylib (libxaw) /usr/local/opt/libxt/lib/libXt.6.dylib (libxt) /usr/local/opt/netcdf/lib/libnetcdf.18.dylib (netcdf) /usr/local/opt/udunits/lib/libudunits2.dylib (udunits)
|
Duplicate of #64777 |
|
all good, thanks for helping out, just trying to finish these last few migrations before big sur |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test not passing. Same issue as with morse: #64333 (comment)
It builds fine, but doesn't really work outside of XQuartz. It does work inside XQuartz though. Will fix the test over the weekend.
Tracking issue: #64166
brew install --build-from-source <formula>, where<formula>is the name of the formula you're submitting?brew test <formula>, where<formula>is the name of the formula you're submitting?brew audit --strict <formula>(after doingbrew install <formula>)?brew install FORMULAon this list (should be poured from a bottle, not built from source)brew linkage FORMULAand observe which X11 libraries it links againstdepends_on :x11and replace it with e.g.depends_on "libx11"and any additional X libraries/opt/X11orMacOS::XQuartzreferences to instead point them to the brewed formula pathsrevisionbumpbrew install -s FORMULAandbrew linkage FORMULAto check that it's now linking against brewed X and not XQuartzBefore:
After: