Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

openmotif, nedit: migrate to brewed X11 #64356

Closed
wants to merge 2 commits into from

Conversation

gromgit
Copy link
Member

@gromgit gromgit commented Nov 8, 2020

Also fixed licenses. Supports #64166.

  • Have you followed the guidelines for contributing?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing brew install <formula>)?

  • brew install FORMULA on this list (should be poured from a bottle, not built from source)
  • Run brew linkage FORMULA and observe which X11 libraries it links against
  • Modify the formula to remove depends_on :x11 and replace it with e.g. depends_on "libx11" and any additional X libraries
  • Update /opt/X11 or MacOS::XQuartz references to instead point them to the brewed formula paths
  • revision bump
  • brew install -s FORMULA and brew linkage FORMULA to check that it's now linking against brewed X and not XQuartz

Also fixed license. Supports Homebrew#64166.
@SeekingMeaning SeekingMeaning mentioned this pull request Nov 8, 2020
45 tasks
Also fixed license. Supports Homebrew#64166.
@gromgit gromgit force-pushed the migrate_openmotif_nedit branch from 4964dfb to 7847f9f Compare November 9, 2020 02:45
Copy link
Contributor

@jonchang jonchang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent work!!

@BrewTestBot
Copy link
Member

🤖 A scheduled task has triggered a merge.

@gromgit gromgit deleted the migrate_openmotif_nedit branch November 9, 2020 08:31
@BrewTestBot BrewTestBot added the outdated PR was locked due to age label Dec 11, 2020
@Homebrew Homebrew locked as resolved and limited conversation to collaborators Dec 11, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants