Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

vint 0.3.21 (new formula) #63333

Closed
wants to merge 2 commits into from
Closed

vint 0.3.21 (new formula) #63333

wants to merge 2 commits into from

Conversation

indygwyn
Copy link
Contributor

  • Have you followed the guidelines for contributing?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing brew install <formula>)?

Adding vim Vint the vimscript linter

@BrewTestBot BrewTestBot added new formula PR adds a new formula to Homebrew/homebrew-core python Python use is a significant feature of the PR or issue labels Oct 22, 2020
dtrodrigues
dtrodrigues reviewed Oct 23, 2020
View reviewed changes
Formula/vint.rb
end

test do
system bin/"vint", "--help"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please add a more substantial test? For instance, you could create a one-line vim file with an error and check to make sure that running vint on it returns the expected warning/error.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yamllint is an example of one approach to test it: https://github.com/Homebrew/homebrew-core/blob/master/Formula/yamllint.rb

@SMillerDev SMillerDev changed the title vint 0.3.21 vint 0.3.21 (new formula) Oct 23, 2020
dtrodrigues
dtrodrigues approved these changes Oct 23, 2020
View reviewed changes
Copy link
Member

@dtrodrigues dtrodrigues left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the updated test and for your first contribution Homebrew @indygwyn!

@BrewTestBot
Copy link
Member

:shipit: @dtrodrigues has triggered a merge.

@indygwyn indygwyn mentioned this pull request Oct 23, 2020
Open
@indygwyn indygwyn deleted the vint branch January 18, 2021 15:43
@BrewTestBot BrewTestBot added the outdated PR was locked due to age label Feb 18, 2021
@Homebrew Homebrew locked as resolved and limited conversation to collaborators Feb 18, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@dtrodrigues dtrodrigues dtrodrigues approved these changes

Assignees
No one assigned
Labels
new formula PR adds a new formula to Homebrew/homebrew-core outdated PR was locked due to age python Python use is a significant feature of the PR or issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@indygwyn @BrewTestBot @dtrodrigues