git-imerge 1.2.0

[mochadwi]

• Have you followed the guidelines for contributing?
• Have you checked that there aren't other open pull requests for the same formula update/change?
• Have you built your formula locally with brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
• Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
• Does your build pass brew audit --strict <formula> (after doing brew install <formula>)?

---

[mochadwi]

I'm opening this PR due to inactivity in: #61471 should I continue on #61471 ?

[Rylan12]

@chenrui333 any progress on #61471? If not, it's fine to continue here.

[mochadwi]

@chenrui333 any progress on #61471? If not, it's fine to continue here.

I've squashed my commit cc @Rylan12

[chenrui333]

looks like the build is still failing? cc @mochadwi

==> brew install --verbose --build-bottle git-imerge
==> FAILED
==> Downloading https://github.com/mhagger/git-imerge/archive/v1.2.0.tar.gz
Already downloaded: /Users/brew/Library/Caches/Homebrew/downloads/462d0e1db00104012afc13fc63c1d5d471e20845dddc08a3ea8601c7053444e7--git-imerge-1.2.0.tar.gz
==> Verifying 462d0e1db00104012afc13fc63c1d5d471e20845dddc08a3ea8601c7053444e7--git-imerge-1.2.0.tar.gz checksum
/usr/bin/sandbox-exec -f /private/tmp/homebrew20201006-62995-ybbo21.sb nice ruby -W0 -I $LOAD_PATH -- /usr/local/Homebrew/Library/Homebrew/build.rb /usr/local/Homebrew/Library/Taps/homebrew/homebrew-core/Formula/git-imerge.rb --build-bottle --verbose
tar xof /Users/brew/Library/Caches/Homebrew/downloads/462d0e1db00104012afc13fc63c1d5d471e20845dddc08a3ea8601c7053444e7--git-imerge-1.2.0.tar.gz -C /private/tmp/d20201006-62996-1ae5gse
cp -pR /private/tmp/d20201006-62996-1ae5gse/git-imerge-1.2.0/. /private/tmp/git-imerge-20201006-62996-kd16kr/git-imerge-1.2.0
chmod -Rf +w /private/tmp/d20201006-62996-1ae5gse
==> make install DESTDIR=/usr/local/Cellar/git-imerge/1.2.0 PREFIX=
make: *** No rule to make target `install'.  Stop.

[mochadwi]

looks like the build is still failing? cc @mochadwi

==> brew install --verbose --build-bottle git-imerge
==> FAILED
==> Downloading https://github.com/mhagger/git-imerge/archive/v1.2.0.tar.gz
Already downloaded: /Users/brew/Library/Caches/Homebrew/downloads/462d0e1db00104012afc13fc63c1d5d471e20845dddc08a3ea8601c7053444e7--git-imerge-1.2.0.tar.gz
==> Verifying 462d0e1db00104012afc13fc63c1d5d471e20845dddc08a3ea8601c7053444e7--git-imerge-1.2.0.tar.gz checksum
/usr/bin/sandbox-exec -f /private/tmp/homebrew20201006-62995-ybbo21.sb nice ruby -W0 -I $LOAD_PATH -- /usr/local/Homebrew/Library/Homebrew/build.rb /usr/local/Homebrew/Library/Taps/homebrew/homebrew-core/Formula/git-imerge.rb --build-bottle --verbose
tar xof /Users/brew/Library/Caches/Homebrew/downloads/462d0e1db00104012afc13fc63c1d5d471e20845dddc08a3ea8601c7053444e7--git-imerge-1.2.0.tar.gz -C /private/tmp/d20201006-62996-1ae5gse
cp -pR /private/tmp/d20201006-62996-1ae5gse/git-imerge-1.2.0/. /private/tmp/git-imerge-20201006-62996-kd16kr/git-imerge-1.2.0
chmod -Rf +w /private/tmp/d20201006-62996-1ae5gse
==> make install DESTDIR=/usr/local/Cellar/git-imerge/1.2.0 PREFIX=
make: *** No rule to make target `install'.  Stop.

Is this a problem with make executable?

[SMillerDev]

That error looks like there is no make install

[mochadwi]

make: *** No rule to make target `install'.  Stop.

Looks like the library author has some improvement in installation process, will modify this later

[yous]

git-imerge switched to use setup.py instead of Makefile: mhagger/git-imerge#143

[mochadwi]

git-imerge switched to use setup.py instead of Makefile: mhagger/git-imerge#143

That's right. I've edit it to use pip for def install. Is it okay?

[yous]

I think we need to do python3 setup.py install. By looking around other formulae,

def install
  system Formula["[email protected]"].opt_bin/"python3", "setup.py", "install",
         "--prefix=#{prefix}",
         "--single-version-externally-managed",
         "--record=installed.txt"
end

Also depends_on "[email protected]" should be added.

[Rylan12]

You'll likely want to look into using virtualenv_install_with_resources (there are lots of formulae that use this you can look at for reference)

If that doesn't work you'll probably need to use something like:

system Formula["[email protected]"].opt_bin/"python3", *Language::Python.setup_install_args(libexec)

Off the top of my head, I think you can use the urh formula as reference.

I'd also recommend switching to using the PyPI URL (in this case, https://files.pythonhosted.org/packages/be/f6/ea97fb920d7c3469e4817cfbf9202db98b4a4cdf71d8740e274af57d728c/git-imerge-1.2.0.tar.gz). That way, brew bump-formula-pr will automatically add resource blocks if they become necessary in the future. This is not a deal-breaker though.

[mochadwi]

It fails when try to installing in my end: mhagger/git-imerge#153

Any ideas to support this bash_completions in macOS?

[Rylan12]

You can install completions to the bash_completion or zsh_completion path. I don't know an example off the top of my head but if you search for bash_completion you should get lots of results.

[mochadwi]

You can install completions to the bash_completion or zsh_completion path. I don't know an example off the top of my head but if you search for bash_completion you should get lots of results.

 depends_on "bash-completion"
 def install
  // install git-imerge
 end

also doesn't works, any ideas to configure bash completion inside Formula/git-imerge.rb?

[mochadwi]

came accross this approach: https://discourse.brew.sh/t/conditional-depends-on-on-formulae/1943/4

does it still relevant in the latest homebrew version using bash_completion.install? if yes, where to put bash_completion.install line?

[Rylan12]

Yes, bash_completion.install is the way to go. You don't need to depend on the bash-completion formula to use it. The bash_completion.install line goes in the install method (usually toward the bottom but I don't think that's a rule).

One example is the velero formula but there are countless more available for reference in Homebrew/core:

homebrew-core/Formula/velero.rb

Lines 28 to 34 in b80fdc6

	# Install bash completion
	output = Utils.safe_popen_read("#{bin}/velero", "completion", "bash")
	(bash_completion/"velero").write output
	# Install zsh completion
	output = Utils.safe_popen_read("#{bin}/velero", "completion", "zsh")
	(zsh_completion/"_velero").write output

[mochadwi]

mhagger/git-imerge#176 the author now skip the bash_completion on ZSH shell

[BrewTestBot]

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

[chenrui333]

Close in favor of #66058