Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ble-sh/blesh 0.3.2 (new formula) #51308

Closed

Conversation

pthariensflame
Copy link
Contributor

  • Have you followed the guidelines for contributing?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing brew install <formula>)? see note

audit fails with only one error, and that one is unavoidable: there are files in lib that shouldn't be there. Unfortunately, for this particular software, they should be there, and if they're moved then the top-level script can't find them anymore.

@BrewTestBot
Copy link
Member

  • GitHub repository not notable enough (<30 forks, <30 watchers and <75 stars)


def install
system Formula["make"].bin/"gmake"
system Formula["make"].bin/"gmake", "INSDIR=#{prefix}", "install"
Copy link

@akinomyoga akinomyoga Mar 8, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

audit fails with only one error, and that one is unavoidable: there are files in lib that shouldn't be there. Unfortunately, for this particular software, they should be there, and if they're moved then the top-level script can't find them anymore.

The directory lib in the install target does not correspond to the directory something like /usr/local/lib but to /usr/local/share/blesh/lib. I'm not familiar with homebrew philosophy, but I guess this should be something like the following:

Suggested change
system Formula["make"].bin/"gmake", "INSDIR=#{prefix}", "install"
system Formula["make"].bin/"gmake", "INSDIR=#{prefix}/share/blesh", "install"

@SMillerDev
Copy link
Member

Hi, this seems like a nice software, but not notable enough for us to package in Homebrew for now. This is not a decision on the merits of the software, but we cannot distribute every single piece of software and have to draw a line on “notability” somewhere. Of course, we would be happy to reconsider in the future.

Please consider hosting it in a personal tap, which is very easy to do: https://docs.brew.sh/How-to-Create-and-Maintain-a-Tap

@SMillerDev SMillerDev closed this Mar 8, 2020
@lock lock bot added the outdated PR was locked due to age label Apr 19, 2020
@lock lock bot locked as resolved and limited conversation to collaborators Apr 19, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants