-
-
Notifications
You must be signed in to change notification settings - Fork 12.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added Sierra bottle sha256 for rust #4960
Conversation
This won't work unfortunately; you need to wait for us to build and upload one and @zmwangx can provide more details on why this wasn't done already. |
@MikeMcQuaid ah, ok. Was trying to figure out how to get a sierra bottle (it takes hours to build from source). |
Now it won't build from source. Which is why we don't have a bottle. |
Ah, maybe that's what up. My source build just ran for 4-5 hours and I finally bailed. |
@zmwangx Maybe worth a Maximum OS X requirement? |
According to my experience it should get stuck early. |
Always good to set |
If it saves people 4-5 hours, definitely, will do right away. |
See Homebrew#4960 for an example of an unfortunate soul who wasted 4-5 valuable hours in his life just because we let him.
See #4962 which temporarily disables it on Sierra. |
Just tested again. It gets caught in a loop after that malloc error after about ~45 minutes (at 78%). |
Yeah that's exactly the "expected" behavior. |
Hello! I work over on the rust-lang/rust project, and I think I know what's going on here. This bug was first reported on July 5, 2016 and was subsequently fixed on July 9, 2016. The fix was originally scheduled to go out in the 1.12 compiler but we backported the fix to the 1.11 compiler. This means that versions of Rust 1.10 and below are all broken on OSX 10.12. When building from source, however, we build from the previous stable version. That is, when building the 1.11 compiler, it uses the 1.10 compiler to kick off the compilation. I believe the problem you're seeing here is that when compiling the 1.11 compiler on OSX 10.12 you need to run the 1.10 compiler, which exhibits this bug. We currently, and unfortunately, have no way to update the boostrap compiler for the 1.11 release. You could work around this by rebuilding 1.10 with an updated jemalloc and then using that to bootstrap 1.11. That being said, the 1.12 release is being released tomorrow (Sep 29, 2016). This compiler will bootstrap from the 1.11 release, which does indeed work on OSX 10.12, so the bootstrap should be able to proceed as usual. Basically tl;dr; this'll fix itself in 24 hours! |
Rust 1.12 was just released! |
Thanks @alexcrichton. Appreciate the update yesterday & today ❤️. If you have a moment, do you have an opinion on the |
Certainly! Commented on them |
brew install <formula>
(where<formula>
is the name of the formula you're submitting)?brew audit --new-formula <formula>
(after doingbrew install <formula>
)?