Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bumpversion 0.5.11 #47379

Closed
wants to merge 1 commit into from
Closed

Conversation

chenrui333
Copy link
Member

  • Have you followed the guidelines for contributing?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing brew install <formula>)?

@SMillerDev
Copy link
Member

Is there a 'blessing' from the old project to continue as a fork? We don't just change upstreams without a very good reason and confirmation from the original upstream.

@chenrui333
Copy link
Member Author

@SMillerDev yeah, he did even put a commit saying the future work would go to the fork (even though there might be potential work needed to merge the fork back to main).

peritus/bumpversion@cc3c8cf

@chenrui333
Copy link
Member Author

The fork is completely drop-in replacement.

And I think the fork would be promoted to its own repo shortly.

@SMillerDev
Copy link
Member

It just tells you to contribute to a fork with "c4urself" being an example. None of this actually mentions that the fork is now the official project.

@SMillerDev
Copy link
Member

@Homebrew/core any opinions?

@SMillerDev SMillerDev added the maintainer feedback Additional maintainers' opinions may be needed label Dec 2, 2019
@chenrui333
Copy link
Member Author

🎬If you want to start using bumpversion, you're best advised to install one of the maintained forks, e.g. ➡ @c4urself's bump2version <https://github.com/c4urself/bump2version/#installation>_.

I think this is pretty clear that is the actively maintained fork, but yeah, it might take some time to become official repo.

@SMillerDev
Copy link
Member

one of the maintained forks, e.g.

So there are multiple and this is an example.

@chenrui333
Copy link
Member Author

Yeah, I think so. Considering the last activity for the main repo was four or five years back, this change might be beneficial.

I will also create an upstream issue to get them sorted out and turn this back to track.

@MikeMcQuaid
Copy link
Member

Given it's "blessed" by the original project maintainer: 👍 to this change.

@Bo98
Copy link
Member

Bo98 commented Dec 2, 2019

To emphasise the GitHub issue mentioned in the formula: c4urself/bump2version#86

It seems like the plan is for either that specified fork to eventually merge back into the main one or for the main repo to be transferred to the individual(s) managing the fork. It's probably as "official" as it's going to get without being official.

@sjackman
Copy link
Member

sjackman commented Dec 4, 2019

@c4urself Could you ask @peritus for commit rights to https://github.com/peritus/bumpversion?

@chenrui333
Copy link
Member Author

There is ongoing discussion for this, I think instead of merging back, it would be nice to promote the fork to become as official repo.

@chenrui333
Copy link
Member Author

what is the take now? merge or close?

@sjackman
Copy link
Member

sjackman commented Dec 9, 2019

Ideally @peritus would either grant commit rights to @c4urself, or alternatively transfer the GitHub repo to @c4urself.

@MikeMcQuaid approved this PR in #47379 (comment). That's good enough for me.

@peritus
Copy link

peritus commented Dec 9, 2019

I did give @c4urself access to both my repository and the PyPI project a few weeks ago: c4urself/bump2version#86 (comment)

@c4urself
Copy link

c4urself commented Dec 9, 2019

Yep, it's on my radar -- going to spend some time on that this week hopefully.

@chenrui333
Copy link
Member Author

Thanks @peritus, @c4urself!! I will give this PR a go and iterate on top of it.

@chenrui333
Copy link
Member Author

@BrewTestBot test this please

@lock lock bot added the outdated PR was locked due to age label Jan 9, 2020
@lock lock bot locked as resolved and limited conversation to collaborators Jan 9, 2020
@chenrui333 chenrui333 deleted the bumpversion-0.5.11 branch December 18, 2022 04:33
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
maintainer feedback Additional maintainers' opinions may be needed outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants