Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

hfstospell 0.5.1 #45845

Closed
wants to merge 2 commits into from
Closed

hfstospell 0.5.1 #45845

wants to merge 2 commits into from

Conversation

osimola
Copy link
Contributor

@osimola osimola commented Oct 26, 2019

  • Have you followed the guidelines for contributing?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing brew install <formula>)?

According to discussion at hfst/hfst-ospell#48, the package isn't really supposed to be buildable without disabling libxml++.

@chenrui333
Copy link
Member

10:39:55 ==> brew linkage --test libvoikko
10:39:57 ==> FAILED
10:39:57 Broken dependencies:
10:39:57 /usr/local/opt/hfstospell/lib/libhfstospell.10.dylib (hfstospell)

@chenrui333
Copy link
Member

You might need a revision bump for libvoikko

@chenrui333 chenrui333 added the build failure CI fails while building the software label Oct 26, 2019
@osimola
Copy link
Contributor Author

osimola commented Oct 26, 2019

Done. I don't see any reason why one would be needed as there are no API changes, but hfstospell maintainer thinks otherwise or just doesn't care.

@chenrui333
Copy link
Member

chenrui333 commented Oct 26, 2019 •
edited
Loading

Looks like the build still failed, i might be wrong on the revision bump side.

16:38:31 ==> brew audit hfstospell --online
16:39:14 ==> FAILED
16:39:14 ==> Installing 'bundler' gem
16:39:14 Successfully installed bundler-2.0.2
16:39:14 1 gem installed
16:39:14 Error: 1 problem in 1 formula detected
16:39:14 hfstospell:
16:39:14 * revisions should only increment by 1

the revision line needs to be removed.

chenrui333
chenrui333 reviewed Oct 26, 2019
View reviewed changes
Formula/hfstospell.rb Outdated
url "https://github.com/hfst/hfst-ospell/releases/download/v0.5.0/hfstospell-0.5.0.tar.gz"
sha256 "0fd2ad367f8a694c60742deaee9fcf1225e4921dd75549ef0aceca671ddfe1cd"
url "https://github.com/hfst/hfst-ospell/releases/download/v0.5.1/hfstospell-0.5.1.tar.gz"
sha256 "ccf5f3b06bcdc5636365e753b9f7fad9c11dfe483272061700a905b3d65ac750"
revision 6
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
revision 6

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That line can be removed.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@chenrui333 chenrui333 removed the build failure CI fails while building the software label Oct 27, 2019
@chenrui333
Copy link
Member

Thanks @osimola!!

@lock lock bot added the outdated PR was locked due to age label Jan 5, 2020
@lock lock bot locked as resolved and limited conversation to collaborators Jan 5, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@chenrui333 chenrui333 chenrui333 approved these changes

Assignees
No one assigned
Labels
outdated PR was locked due to age
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@osimola @chenrui333