macvim 8.1-159

[henryiii]

Created with brew bump-formula-pr.

Fixes #44995, replaces #45016 and #45454. New version should be fine on Catalina.

[SMillerDev]

Thanks @henryiii! Without contributions like yours it'd be impossible to keep homebrew going with the high standards that users have come to expect from the project. You can feel good knowing that you've made the world a tiny bit better for homebrew users around the world! 👍 🎉

[mvcouwen]

@henryiii Awesome work! Thanks! Have been waiting for this.
Will a bottle for Catalina be made automatically? (my first time to follow a bump this closely)

[henryiii]

All I did was run one line:

brew bump-formula-pr macvim --version=8.1-159 --url=https://github.com/macvim-dev/macvim/archive/snapshot-159.tar.gz

(and I've logged in a some point in the past so the github api calls work). It wasn't that much work. ;)

And yes, bottles will be built, and if it works, they get added when this gets merged.

[mvcouwen]

The same problem as in #45016 seems to persist. There seems to be a problem with ruby and Mojave. The test shows Ruby 2.6 although Mojave ships with Ruby 2.3. Is there a problem with the test or with this new version of macvim?

[henryiii]

How could it only fail Mojave but not High sierra if it was Vim's fault? Not saying it is not, just very odd.

[mvcouwen]

The exact same issue happened before when trying to update macvim: a34b0b3
Apparently, it is an issue with the precompiled bottle for Mojave (Sierra back then): macvim-dev/macvim#549

[fxcoudert]

Should we (temporarily or permanently) ship macvim without Ruby interpreter? How crucial is it to users?

[mvcouwen]

@fxcoudert That is a possibility but I do not know how many users use the Ruby interpreter.

On the other hand, as @henryiii pointed out, it seems more likely that this is a homebrew/test problem rather than a problem with macvim. If we could figure out how it got solved before, cf. a34b0b3 , we might be able to solve this quickly.

[chenrui333]

Hi all, just FYI I have merged #45624, let me know if it works for you guys.

[chenrui333]

Closing the PR now as the upgrade is done.

[henryiii]

Everything seemed to be fine yesterday! (Just got back from travels without Catalina)