openexr & ilmbase 2.4.0 #44807

equal-l2 · 2019-10-02T09:00:14Z

Created with brew bump-formula-pr.

Formula/openexr.rb

equal-l2 · 2019-10-03T05:08:09Z

It seems that ilmbase now requires C++11 (headers use C++11 grammar).
@fxcoudert How can I handle this?

equal-l2 · 2019-10-03T10:33:28Z

Adding ENV.cxx11 to all dependents?

SMillerDev · 2019-10-19T19:30:41Z

@equal-l2 could you rebase on master? And isn't C11 the default nowadays?

equal-l2 · 2019-10-20T09:35:20Z

pkgconfig file generated by openexr seems broken.
AcademySoftwareFoundation/openexr#567

EDIT: resolved with AcademySoftwareFoundation/openexr#608.

equal-l2 · 2019-11-13T01:45:02Z

ctl has something wrong in its linking phase:
EDIT: This can be fixed by appending -lImath to the linking flags.

[ 46%] Linking CXX shared library libIlmCtlMath.dylib
cd /tmp/ctl-20191112-70143-1hy43yz/CTL-ctl-1.5.2/build/lib/IlmCtlMath && /usr/local/Cellar/cmake/3.15.5/bin/cmake -E cmake_link_script CMakeFiles/IlmCtlMath.dir/link.txt --verbose=1
/usr/local/Homebrew/Library/Homebrew/shims/mac/super/clang++   -DNDEBUG -isysroot /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.15.sdk -dynamiclib -Wl,-headerpad_max_install_names   -o libIlmImfCtl.dylib -install_name /tmp/ctl-20191112-70143-1hy43yz/CTL-ctl-1.5.2/build/lib/IlmImfCtl/libIlmImfCtl.dylib CMakeFiles/IlmImfCtl.dir/ImfCtlApplyTransforms.cpp.o CMakeFiles/IlmImfCtl.dir/ImfCtlCopyFunctionArg.cpp.o  -L/usr/local/Cellar/ilmbase/2.4.0/lib  -L/usr/local/Cellar/openexr/2.4.0/lib -Wl,-rpath,/usr/local/Cellar/ilmbase/2.4.0/lib -Wl,-rpath,/usr/local/Cellar/openexr/2.4.0/lib ../IlmCtl/libIlmCtl.1.5.0.dylib -lIlmImf -lIex -lIlmThread -lHalf 
/usr/local/Homebrew/Library/Homebrew/shims/mac/super/clang++   -DNDEBUG -isysroot /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.15.sdk -dynamiclib -Wl,-headerpad_max_install_names   -compatibility_version 1.5.0 -current_version 1.5.0 -o libIlmCtlMath.1.5.0.dylib -install_name /tmp/ctl-20191112-70143-1hy43yz/CTL-ctl-1.5.2/build/lib/IlmCtlMath/libIlmCtlMath.1.5.0.dylib CMakeFiles/IlmCtlMath.dir/CtlColorSpace.cpp.o CMakeFiles/IlmCtlMath.dir/CtlLookupTable.cpp.o CMakeFiles/IlmCtlMath.dir/CtlRbfInterpolator.cpp.o  -L/usr/local/Cellar/ilmbase/2.4.0/lib -Wl,-rpath,/usr/local/Cellar/ilmbase/2.4.0/lib ../IlmCtl/libIlmCtl.1.5.0.dylib -lIex -lIlmThread -lHalf 
Undefined symbols for architecture x86_64:
  "Imath_2_4::SingMatrixExc::SingMatrixExc(char const*)", referenced from:
      Imath_2_4::Matrix44<float>::inverse(bool) const in CtlColorSpace.cpp.o
      Imath_2_4::Matrix44<float>::gjInverse(bool) const in CtlColorSpace.cpp.o
  "Imath_2_4::SingMatrixExc::~SingMatrixExc()", referenced from:
      Imath_2_4::Matrix44<float>::inverse(bool) const in CtlColorSpace.cpp.o
      Imath_2_4::Matrix44<float>::gjInverse(bool) const in CtlColorSpace.cpp.o
  "typeinfo for Imath_2_4::SingMatrixExc", referenced from:
      Imath_2_4::Matrix44<float>::inverse(bool) const in CtlColorSpace.cpp.o
      Imath_2_4::Matrix44<float>::gjInverse(bool) const in CtlColorSpace.cpp.o
ld: symbol(s) not found for architecture x86_64
clang: error: linker command failed with exit code 1 (use -v to see invocation)
make[2]: *** [lib/IlmCtlMath/libIlmCtlMath.1.5.0.dylib] Error 1
make[1]: *** [lib/IlmCtlMath/CMakeFiles/IlmCtlMath.dir/all] Error 2
make[1]: *** Waiting for unfinished jobs....
[ 46%] Built target IlmImfCtl
make: *** [all] Error 2

field3d (SCons) seems to be ignoring ENV.cxx11:

Compiling �[1mbuild/darwin/m64/release/FieldCache.os�[0m
In file included from src/ClassFactory.cpp:44:
In file included from export/ClassFactory.h:50:
In file included from export/Field.h:55:
In file included from export/Traits.h:54:
In file included from export/Types.h:56:
In file included from export/StdMathLib.h:43:
In file included from /usr/local/include/OpenEXR/ImathColor.h:48:
/usr/local/include/OpenEXR/half.h:99:15: warning: defaulted function definitions are a C++11 extension [-Wc++11-extensions]
    half () = default;                  // no initialization
              ^
/usr/local/include/OpenEXR/half.h:102:16: warning: defaulted function definitions are a C++11 extension [-Wc++11-extensions]
    ~half () = default;
               ^
/usr/local/include/OpenEXR/half.h:103:27: warning: defaulted function definitions are a C++11 extension [-Wc++11-extensions]
    half (const half &) = default;
                          ^
/usr/local/include/OpenEXR/half.h:104:16: warning: rvalue references are a C++11 extension [-Wc++11-extensions]
    half (half &&) noexcept = default;
               ^
/usr/local/include/OpenEXR/half.h:104:19: error: expected ';' at end of declaration list
    half (half &&) noexcept = default;
                  ^
                  ;
/usr/local/include/OpenEXR/half.h:124:43: warning: defaulted function definitions are a C++11 extension [-Wc++11-extensions]
    half &              operator = (const half  &h) = default;
                                                      ^
/usr/local/include/OpenEXR/half.h:125:31: warning: rvalue references are a C++11 extension [-Wc++11-extensions]
    half &              operator = (half  &&h) noexcept = default;
                                          ^
/usr/local/include/OpenEXR/half.h:125:35: error: expected ';' at end of declaration list
    half &              operator = (half  &&h) noexcept = default;
                                              ^
                                              ;

Bo98 · 2019-11-23T04:44:41Z

Just going to mark this as "do not merge" until we've merged in Python 3.8 (#45337), due to merge conflicts. Feel free to keep working on this though and we'll be able to help out where need be.

fxcoudert · 2019-12-26T14:02:48Z

CI does not handle merge commits well, please rebase on top of master.

fxcoudert · 2019-12-26T17:35:13Z

Also need a revision: openimageio vips
ctl and field3d still need to be fixed

equal-l2 · 2019-12-26T19:15:28Z

@fxcoudert
Thanks for pointing out, I'll revision them soon.

As for ctl and field3d, I know what is the problem but I have no idea how to fix them. Any help is welcome.

All I have to do is:

ctl : The linking error is due to the lack of libImath, thus add -lImath to the linking flags
field3d : All the error is due to using the old C++ standard, thus tell scons to use C++11

equal-l2 · 2019-12-31T00:51:04Z

Can I propose deletion of ctl and field3d, since both are unmaintained (judging from having no commit for over two years) and are blocking this PR?

zbeekman · 2020-01-04T19:37:07Z

Can I propose deletion of ctl and field3d, since both are unmaintained (judging from having no commit for over two years) and are blocking this PR?

@equal-l2 can we apply imageworks/Field3D#97 as part of this PR while we wait for upstream to merge? Also, if ampas/CTL#73 resolves the ctl issue could that be applied as part of this PR as well?

equal-l2 · 2020-01-06T02:19:13Z

@fxcoudert I fixed every problems mentioned.

fxcoudert · 2020-01-06T09:41:23Z

Excellent work! Thanks @equal-l2 for your contribution to Homebrew

fxcoudert reviewed Oct 2, 2019

View reviewed changes

Formula/openexr.rb Show resolved Hide resolved

equal-l2 force-pushed the openexr-2.4.0 branch from 96a67ee to fff1d1b Compare October 2, 2019 19:09

equal-l2 changed the title ~~openexr 2.4.0~~ openexr & ilmbase 2.4.0 Oct 3, 2019

equal-l2 force-pushed the openexr-2.4.0 branch from fff1d1b to 8a12920 Compare October 3, 2019 01:15

SMillerDev added the needs response Needs a response from the issue/PR author label Oct 19, 2019

equal-l2 force-pushed the openexr-2.4.0 branch from 8a12920 to 768df91 Compare October 19, 2019 19:36

equal-l2 force-pushed the openexr-2.4.0 branch 2 times, most recently from c4794b3 to 8e81f81 Compare November 11, 2019 23:47

equal-l2 force-pushed the openexr-2.4.0 branch from 8e81f81 to cd3e87c Compare November 20, 2019 08:01

Bo98 added do not merge python Python use is a significant feature of the PR or issue labels Nov 23, 2019

fxcoudert removed do not merge needs response Needs a response from the issue/PR author labels Dec 26, 2019

equal-l2 force-pushed the openexr-2.4.0 branch from e90a048 to 4e43aa1 Compare December 26, 2019 14:43

This was referenced Jan 3, 2020

ctl: delete #48498

Closed

field3d: delete #48499

Closed

equal-l2 added 3 commits January 5, 2020 09:44

openexr 2.4.0

3248f7b

ilmbase 2.4.0

b5ef03a

ctl: revision, use C++11 and add patch

e8cd3ea

equal-l2 added 10 commits January 5, 2020 09:44

field3d: revision and use C++11

9d9d520

imagemagick: revision bump

72223ea

opencv: revision bump

1335ecf

opencv@3: revision bump

00c3858

openvdb: revision bump

759deb0

rawtoaces: revision and use C++11

3d21a66

synfig: revision bump

c129c3a

opencv@2: revision and use C++11

9d7d181

openimageio: revision bump

ab4b454

vips: revision bump

1de2d0f

equal-l2 force-pushed the openexr-2.4.0 branch from 4e43aa1 to 1de2d0f Compare January 5, 2020 00:53

opencv: don't remove libIlmImf.a, which doesn't exist

55b1174

fxcoudert closed this in e41d80b Jan 6, 2020

equal-l2 deleted the openexr-2.4.0 branch January 6, 2020 19:21

lock bot added the outdated PR was locked due to age label Feb 5, 2020

lock bot locked as resolved and limited conversation to collaborators Feb 5, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

openexr & ilmbase 2.4.0 #44807

openexr & ilmbase 2.4.0 #44807

equal-l2 commented Oct 2, 2019

equal-l2 commented Oct 3, 2019 •

edited

Loading

equal-l2 commented Oct 3, 2019

SMillerDev commented Oct 19, 2019

equal-l2 commented Oct 20, 2019 •

edited

Loading

equal-l2 commented Nov 13, 2019 •

edited

Loading

Bo98 commented Nov 23, 2019

fxcoudert commented Dec 26, 2019

fxcoudert commented Dec 26, 2019 •

edited

Loading

equal-l2 commented Dec 26, 2019 •

edited

Loading

equal-l2 commented Dec 31, 2019

zbeekman commented Jan 4, 2020

equal-l2 commented Jan 6, 2020

fxcoudert commented Jan 6, 2020

openexr & ilmbase 2.4.0 #44807

openexr & ilmbase 2.4.0 #44807

Conversation

equal-l2 commented Oct 2, 2019

equal-l2 commented Oct 3, 2019 • edited Loading

equal-l2 commented Oct 3, 2019

SMillerDev commented Oct 19, 2019

equal-l2 commented Oct 20, 2019 • edited Loading

equal-l2 commented Nov 13, 2019 • edited Loading

Bo98 commented Nov 23, 2019

fxcoudert commented Dec 26, 2019

fxcoudert commented Dec 26, 2019 • edited Loading

equal-l2 commented Dec 26, 2019 • edited Loading

equal-l2 commented Dec 31, 2019

zbeekman commented Jan 4, 2020

equal-l2 commented Jan 6, 2020

fxcoudert commented Jan 6, 2020

equal-l2 commented Oct 3, 2019 •

edited

Loading

equal-l2 commented Oct 20, 2019 •

edited

Loading

equal-l2 commented Nov 13, 2019 •

edited

Loading

fxcoudert commented Dec 26, 2019 •

edited

Loading

equal-l2 commented Dec 26, 2019 •

edited

Loading