-
-
Notifications
You must be signed in to change notification settings - Fork 12.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
boost 1.70.0 #38890
boost 1.70.0 #38890
Conversation
|
This is weird; why is
|
I think a similar thing happened to |
@scpeters the fact that they build out of order is a missed optimisation, but not in itself a problem. The dependencies will then build from source, and while it will take longer, it should still work. |
The most serious problem is that many packages using
but with boost-1.70.0, we get this:
|
Trying to rebuild Edit: didn't work. But, upon further analysis, all packages that fail with this error are CGAL-related, so I filed it as a CGAL issue CGAL/cgal#3851 |
Maybe the update in #38904 will fix it.
This issue was reported at microsoft/cpprestsdk#1054 and closed but not fixed. |
@BrewTestBot test this please |
|
Thanks for the reminder about this behavior. I guess it may happen very often that it fails to find bottles and rebuilds from source, but I only see the console message when it fails, so it can be misleading. |
regarding the error
I'll paste here a relevant comment from Patrick Volkerding in the Slackware ChangeLog
|
|
@fxcoudert commented on Apr 13, 2019, 12:22 PM GMT+2:
As far as I can see in the discussion, there are other packages, not related to CGAL, that fail to build. @fxcoudert commented on Apr 15, 2019, 1:11 PM GMT+2:
It seems to be an incoherence between On Linux, with Brew, |
Yes, but usually with different errors 😢
No, it is not something we (Homebrew) are setting. |
I've been looking at the cgal issues a little, but so far it's just been tinkering with their travis scripts to try to enable macOS CI to make it easier to reproduce these failures. No solutions yet. |
18c2c54
to
ba9d1ae
Compare
|
I've manually edited patches for monero and cpprestsdk based on upstream. Not sure if they will work, but cannot test locally right now. |
Woohoo finally merged! Many many thanks to @scpeters |
I faced this error while building my program. I guess it can be related to this issue? I am using boost 1.70.0 downloaded by brew on MacOS High Sierra 10.13.6. (I used
|
@rbooo567 yes you need to make your program compatible with boost's changes in asio |
@fxcoudert A slight misunderstanding by @Al2Klimov how source and bottles work, all things sorted out, thanks. We're developing icinga2 on our Macbooks and using Homebrew's Boost for this. 1.70 and its breaking changes came to our attention with FreeBSD's updates, and using Homebrew is just an awesome possibility :) |
Created with
brew bump-formula-pr
.