Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

protobuf 3.5.2 (new formula) #32276

Closed
wants to merge 1 commit into from
Closed

Conversation

npars
Copy link

@npars npars commented Sep 20, 2018

  • Have you followed the guidelines for contributing?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing brew install <formula>)?

This is just a duplicate of @ilovezfs's implementation for 3.5.1 (located here) upgraded to 3.5.2.

#29295 states that 3.5 was not added due to lack of maintenance but the 3.6.0 release mentions that:

Starting from this release, we now require C++11. For those we cannot yet upgrade to C++11, we will try to keep the 3.5.x branch updated with critical bug fixes only. If you have any concerns about this, please comment on issue protocolbuffers/protobuf#2780.

I feel like that is enough to warrant adding the formula.

@lembacon lembacon added new formula PR adds a new formula to Homebrew/homebrew-core legacy Relates to a versioned @ formula labels Sep 20, 2018
@fxcoudert
Copy link
Member

We probably want to use this opportunity to sort out the many protobuf versions that we have… [email protected] [email protected] [email protected] + latest.

keg_only :versioned_formula

# this will double the build time approximately if enabled
option "with-test", "Run build-time check"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No test or check option, like current protobuf.rb

@stale
Copy link

stale bot commented Oct 11, 2018

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@stale stale bot added the stale No recent activity label Oct 11, 2018
@stale stale bot closed this Oct 18, 2018
@lock lock bot added the outdated PR was locked due to age label Nov 17, 2018
@lock lock bot locked as resolved and limited conversation to collaborators Nov 17, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
legacy Relates to a versioned @ formula new formula PR adds a new formula to Homebrew/homebrew-core outdated PR was locked due to age stale No recent activity
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants