Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wownero 0.11.3.0 #201538

Merged
merged 2 commits into from
Dec 21, 2024
Merged

wownero 0.11.3.0 #201538

merged 2 commits into from
Dec 21, 2024

Conversation

iMichka
Copy link
Member

@iMichka iMichka commented Dec 17, 2024

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

@github-actions github-actions bot added formula disabled Formula disabled boost Boost use is a significant feature of the PR or issue labels Dec 17, 2024
@iMichka
Copy link
Member Author

iMichka commented Dec 17, 2024

It does not build with the new boost version, but at least the workarounds are now gone

@chenrui333
Copy link
Member

It does not build with the new boost version, but at least the workarounds are now gone

any upstream issue for tracking the latest boost support?

@iMichka
Copy link
Member Author

iMichka commented Dec 17, 2024

The error was:

[ 50%] Built target obj_checkpoints
In file included from /tmp/wownero-20241217-43103-4xycsi/src/cryptonote_core/tx_pool.cpp:40:
/tmp/wownero-20241217-43103-4xycsi/src/cryptonote_core/blockchain.h:32:10: fatal error: 'boost/asio/io_service.hpp' file not found
   32 | #include <boost/asio/io_service.hpp>
      |          ^~~~~~~~~~~~~~~~~~~~~~~~~~~
In file included from /tmp/wownero-20241217-43103-4xycsi/src/cryptonote_core/tx_sanity_check.cpp:33:
/tmp/wownero-20241217-43103-4xycsi/src/cryptonote_core/blockchain.h:32:10: fatal error: 'boost/asio/io_service.hpp' file not found
   32 | #include <boost/asio/io_service.hpp>
      |          ^~~~~~~~~~~~~~~~~~~~~~~~~~~
1 error generated.
make[2]: *** [src/cryptonote_core/CMakeFiles/obj_cryptonote_core.dir/tx_verification_utils.cpp.o] Error 1
1 error generated.
make[2]: *** [src/cryptonote_core/CMakeFiles/obj_cryptonote_core.dir/tx_pool.cpp.o] Error 1
1 error generated.
make[2]: *** [src/cryptonote_core/CMakeFiles/obj_cryptonote_core.dir/tx_sanity_check.cpp.o] Error 1
In file included from /tmp/wownero-20241217-43103-4xycsi/src/cryptonote_core/cryptonote_tx_utils.cpp:40:
/tmp/wownero-20241217-43103-4xycsi/src/cryptonote_core/blockchain.h:32:10: fatal error: 'boost/asio/io_service.hpp' file not found
   32 | #include <boost/asio/io_service.hpp>
      |          ^~~~~~~~~~~~~~~~~~~~~~~~~~~
[ 51%] Linking CXX static library librandomx.a

I did not have time to check with upstream yet.

@iMichka iMichka marked this pull request as draft December 17, 2024 22:20
@iMichka
Copy link
Member Author

iMichka commented Dec 17, 2024

Wownero is a fork of monero. See monero-project/monero#9596, they have/will have similar issue. CC @cho-m FYI.

@iMichka
Copy link
Member Author

iMichka commented Dec 17, 2024

I have changed this to a draft. I am wondering why the repo URL changed, but https://wownero.org still links to https://git.wownero.com ...

Formula/w/wownero.rb Outdated Show resolved Hide resolved
Formula/w/wownero.rb Outdated Show resolved Hide resolved
@iMichka iMichka marked this pull request as ready for review December 18, 2024 06:30
@iMichka
Copy link
Member Author

iMichka commented Dec 18, 2024

I have changed this to a draft. I am wondering why the repo URL changed, but https://wownero.org still links to https://git.wownero.com ...

That's OK it's a redirect

Copy link
Contributor

🤖 An automated task has requested bottles to be published to this PR.

@github-actions github-actions bot added the CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. label Dec 21, 2024
@BrewTestBot BrewTestBot added this pull request to the merge queue Dec 21, 2024
Merged via the queue into master with commit fa4a11d Dec 21, 2024
15 checks passed
@BrewTestBot BrewTestBot deleted the wownero branch December 21, 2024 06:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
boost Boost use is a significant feature of the PR or issue CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. formula disabled Formula disabled
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants