Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

action-docs 2.5.0 (new formula) #195773

Merged
merged 2 commits into from
Oct 29, 2024
Merged

Conversation

nitrocode
Copy link
Contributor

@nitrocode nitrocode commented Oct 28, 2024

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

@github-actions github-actions bot added nodejs Node or npm use is a significant feature of the PR or issue new formula PR adds a new formula to Homebrew/homebrew-core labels Oct 28, 2024
@chenrui333
Copy link
Member

  action-docs
    * line 33, col 60: Use `bin/"action-docs"` instead of `"#{bin}/action-docs"`

@nitrocode
Copy link
Contributor Author

Thanks @chenrui333. PR checks are all green now. Please re-review when you get a chance.

@chenrui333 chenrui333 added the ready to merge PR can be merged once CI is green label Oct 29, 2024
@nitrocode
Copy link
Contributor Author

nitrocode commented Oct 29, 2024

@chenrui333 thank you for the review. I see that you approved and then force pushed which then removed the approval. Would you mind reviewing again please?

Edit: it says this

Waiting on 1 reapproval from someone other than the last pusher. Review from chenrui333 is stale because it was submitted before the most recent code changes.

Perhaps I should force push a new commit and then you can rereview?

Signed-off-by: nitrocode <[email protected]>

action-docs: update test

Signed-off-by: Rui Chen <[email protected]>

use yaml for heredoc delimiters

Signed-off-by: Rui Chen <[email protected]>
Signed-off-by: nitrocode <[email protected]>
Copy link
Contributor

@chenrui333
Copy link
Member

we dont need commit fresh, I was just making some test code style changes, but it should be all good. thanks @nitrocode.

@github-actions github-actions bot added the CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. label Oct 29, 2024
@BrewTestBot BrewTestBot enabled auto-merge October 29, 2024 15:30
@BrewTestBot BrewTestBot added this pull request to the merge queue Oct 29, 2024
Merged via the queue into Homebrew:master with commit 7b90568 Oct 29, 2024
15 checks passed
@nitrocode nitrocode deleted the action-docs branch October 29, 2024 16:44
@nitrocode
Copy link
Contributor Author

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. new formula PR adds a new formula to Homebrew/homebrew-core nodejs Node or npm use is a significant feature of the PR or issue ready to merge PR can be merged once CI is green
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Homebrew formula for action-docs
3 participants