Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

code-server 4.90.2 #174664

Closed
wants to merge 1 commit into from
Closed

code-server 4.90.2 #174664

wants to merge 1 commit into from

Conversation

BrewTestBot
Copy link
Member

Created by brew bump


Created with brew bump-formula-pr.

@github-actions github-actions bot added nodejs Node or npm use is a significant feature of the PR or issue bump-formula-pr PR was created using `brew bump-formula-pr` labels Jun 16, 2024
@chenrui333
Copy link
Member

> [email protected] postinstall
> sh ./postinstall.sh

ERROR: code-server currently requires node v20.
./postinstall.sh: line 81: FORCE_NODE_VERSION: unbound variable
npm verbose stack Error: command failed
npm verbose stack     at ChildProcess.<anonymous> (/opt/homebrew/Cellar/node@18/18.20.3/lib/node_modules/npm/node_modules/@npmcli/promise-spawn/lib/index.js:53:27)
npm verbose stack     at ChildProcess.emit (node:events:517:28)
npm verbose stack     at maybeClose (node:internal/child_process:1098:16)
npm verbose stack     at ChildProcess._handle.onexit (node:internal/child_process:303:5)
npm verbose pkgid [email protected]
npm verbose cwd /private/tmp/code-server-20240615-6851-nlwvem/package
npm verbose Darwin 21.6.0
npm verbose node v18.20.3
npm verbose npm  v10.7.0
npm error code 1
npm error path /private/tmp/code-server-20240615-6851-nlwvem/package
npm error command failed
npm error command sh -c sh ./postinstall.sh
npm verbose exit 1
npm verbose code 1

@chenrui333 chenrui333 force-pushed the bump-code-server-4.90.2 branch from 0ba93e9 to 752674f Compare June 16, 2024 01:50
code-server: use node@20

Signed-off-by: Rui Chen <[email protected]>
@chenrui333 chenrui333 force-pushed the bump-code-server-4.90.2 branch from 752674f to d482c0f Compare June 16, 2024 02:13
@chenrui333
Copy link
Member

npm error gyp verb node dev dir /private/tmp/code-server-20240615-37528-12y8ws/package/.brew_home/Library/Caches/node-gyp/20.14.0
npm error gyp verb python /Applications/Xcode.app/Contents/Developer/usr/bin/python3
npm error gyp verb `which` succeeded for `make` /opt/homebrew/Library/Homebrew/shims/mac/super/make
npm error gyp verb bin symlinks created symlink to "/Applications/Xcode.app/Contents/Developer/usr/bin/python3" in "/private/tmp/code-server-20240615-37528-12y8ws/package/lib/vscode/node_modules/kerberos/build/node_gyp_bins" and added to PATH
npm error gyp info spawn make
npm error gyp info spawn args [ 'V=1', 'BUILDTYPE=Release', '-C', 'build' ]
npm error In file included from ../src/kerberos.cc:1:
npm error In file included from ../src/kerberos.h:11:
npm error In file included from ../node_modules/node-addon-api/napi.h:2981:
npm error ../node_modules/node-addon-api/napi-inl.h:64:12: error: no matching function for call to 'napi_add_finalizer'
npm error   status = napi_add_finalizer(env, obj, data, finalizer, hint, nullptr);
npm error            ^~~~~~~~~~~~~~~~~~
npm error ../node_modules/node-addon-api/napi-inl.h:2192:29: note: in instantiation of function template specialization 'Napi::details::AttachData<Napi::MethodCallbackData<node_kerberos::KerberosClient, Napi::Value (*)(const Napi::CallbackInfo &)>>' requested here
npm error     status = Napi::details::AttachData(env, *result, data);
npm error                             ^
npm error ../node_modules/node-addon-api/napi-inl.h:4165:16: note: in instantiation of function template specialization 'Napi::CreateFunction<Napi::MethodCallbackData<node_kerberos::KerberosClient, Napi::Value (*)(const Napi::CallbackInfo &)>>' requested here
npm error       status = CreateFunction(env,
npm error                ^
npm error ../node_modules/node-addon-api/napi-inl.h:4224:10: note: in instantiation of member function 'Napi::ObjectWrap<node_kerberos::KerberosClient>::DefineClass' requested here
npm error   return DefineClass(env,
npm error          ^
npm error ../src/kerberos.cc:42:9: note: in instantiation of member function 'Napi::ObjectWrap<node_kerberos::KerberosClient>::DefineClass' requested here
npm error         DefineClass(env,
npm error         ^

@benz0li
Copy link

benz0li commented Jun 16, 2024

@chenrui333 code-server currently requires node v20.

Cross reference:

Copy link
Contributor

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. To keep this pull request open, add a help wanted or in progress label.

@github-actions github-actions bot added the stale No recent activity label Jun 18, 2024
@github-actions github-actions bot closed this Jun 19, 2024
@p-linnane p-linnane deleted the bump-code-server-4.90.2 branch July 3, 2024 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bump-formula-pr PR was created using `brew bump-formula-pr` nodejs Node or npm use is a significant feature of the PR or issue stale No recent activity
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants