Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docker-compose: symlink plugin to brew owned cli-plugins #165406

Merged
merged 2 commits into from
Mar 7, 2024

Conversation

narqo
Copy link
Contributor

@narqo narqo commented Mar 7, 2024

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

The rationale for the change is exactly the same as in #162200 but this time for docker-compose (which is another docker plugin):

[..] as a user I find it more natural to update my local config, to point to a managed directory with plugins, than symlinking the managed plugin into my home directory (i.e. the previous suggestion from "caveats").

@github-actions github-actions bot added the go Go use is a significant feature of the PR or issue label Mar 7, 2024
@chenrui333
Copy link
Member

Thanks @narqo!

Copy link
Contributor

github-actions bot commented Mar 7, 2024

🤖 An automated task has requested bottles to be published to this PR.

@github-actions github-actions bot added the CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. label Mar 7, 2024
@BrewTestBot BrewTestBot enabled auto-merge March 7, 2024 22:43
@BrewTestBot BrewTestBot added this pull request to the merge queue Mar 7, 2024
Merged via the queue into Homebrew:master with commit 6666325 Mar 7, 2024
13 checks passed
@narqo narqo deleted the docker-cli-plugins branch March 8, 2024 08:46
@github-actions github-actions bot added the outdated PR was locked due to age label Apr 7, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 7, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. go Go use is a significant feature of the PR or issue outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants