Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

zipkin 3.0.2 (new formula) #159482

Merged
merged 2 commits into from
Jan 12, 2024
Merged

Conversation

codefromthecrypt
Copy link
Contributor

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

@github-actions github-actions bot added new formula PR adds a new formula to Homebrew/homebrew-core java Java use is a significant feature of the PR or issue labels Jan 10, 2024
@codefromthecrypt codefromthecrypt marked this pull request as draft January 10, 2024 23:40
@codefromthecrypt codefromthecrypt changed the title zipkin 2.17.1 (new formula) zipkin 3.0.0 (new formula) Jan 11, 2024
@codefromthecrypt
Copy link
Contributor Author

bumped to 3.0.0 and will sort out the service stuff next

@codefromthecrypt codefromthecrypt changed the title zipkin 3.0.0 (new formula) zipkin 3.0.2 (new formula) Jan 12, 2024
@codefromthecrypt codefromthecrypt marked this pull request as ready for review January 12, 2024 03:43
@codefromthecrypt
Copy link
Contributor Author

thanks for the advice @chenrui333! zipkin is now a service.

Formula/z/zipkin.rb Outdated Show resolved Hide resolved
@github-actions github-actions bot added the autosquash Automatically squash pull request commits according to Homebrew style. label Jan 12, 2024
Signed-off-by: Adrian Cole <[email protected]>
Co-authored-by: Rui Chen <[email protected]>
@github-actions github-actions bot removed the autosquash Automatically squash pull request commits according to Homebrew style. label Jan 12, 2024
@chenrui333 chenrui333 added the ready to merge PR can be merged once CI is green label Jan 12, 2024
@chenrui333
Copy link
Member

@codefromthecrypt, thanks for your contribution to Homebrew! 🎉 🥇

Without awesome contributors like you, it would be impossible to maintain Homebrew to the high level of quality users have come to expect. Thank you!!!!

Copy link
Contributor

@github-actions github-actions bot added the CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. label Jan 12, 2024
@BrewTestBot BrewTestBot added this pull request to the merge queue Jan 12, 2024
Merged via the queue into Homebrew:master with commit 42984b6 Jan 12, 2024
12 checks passed
@codefromthecrypt codefromthecrypt deleted the zipkin-2.17.1 branch January 13, 2024 00:04
@codefromthecrypt
Copy link
Contributor Author

awesome

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. java Java use is a significant feature of the PR or issue new formula PR adds a new formula to Homebrew/homebrew-core ready to merge PR can be merged once CI is green
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants