Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

jadx 0.6.0 (new formula) #1515

Merged
merged 2 commits into from
May 31, 2016
Merged

jadx 0.6.0 (new formula) #1515

merged 2 commits into from
May 31, 2016

Conversation

agatti
Copy link
Contributor

@agatti agatti commented May 28, 2016

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same formula update/change?
  • Have you built your formula locally prior to submission with brew install <formula> (where <formula> is the name of the formula you're submitting)?
  • Does your submission pass brew audit --strict --online <formula> (after doing brew install <formula>)?

@DomT4 DomT4 added the new formula PR adds a new formula to Homebrew/homebrew-core label May 28, 2016

head do
url "https://github.com/skylot/jadx.git"
depends_on :java => "1.8"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1.8+ probably makes more sense.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This has been addressed in de6e162 - thank you for noticing that.

@MikeMcQuaid MikeMcQuaid merged commit 0b9c3e8 into Homebrew:master May 31, 2016
@MikeMcQuaid
Copy link
Member

Thanks for your contribution to Homebrew! Without people like you submitting PRs we couldn't run this project. You rock!

@Homebrew Homebrew locked and limited conversation to collaborators May 4, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
new formula PR adds a new formula to Homebrew/homebrew-core
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants